Closed Bug 1211364 Opened 6 years ago Closed 6 years ago

Do MDSM::CheckFrameValidity() earlier when video frames arrive MDSM.

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: kikuo, Assigned: kikuo)

References

Details

Attachments

(1 file)

Currently MDSM checks frame validity in MDSM::RenderVideoFrame() and since we'd like to move the frame rendering logic out of MDSM (Bug 1194918 Comment 32), it would be better to check it earlier once video frames arrive MDSM, so that MDSM is able to decided whether turning off HW acceleration in advance if needed.
Assignee: nobody → kikuo
Summary: Do MDSM::CheckFrameValidity() earlier when frames arrive MDSM. → Do MDSM::CheckFrameValidity() earlier when video frames arrive MDSM.
Blocks: 1194918
Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM; r?jwwang
Attachment #8669797 - Flags: review?(jwwang)
Depends on: 1196408
Comment on attachment 8669797 [details]
MozReview Request: Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.

Looks fine to me. But I am not sure if there are concerns if we count corrupted frames when they arrive MDSM instead of when they are rendered.

But it surely fixes the problem bug 1196408 tried to fix where corrupted frames are counted multiple times.
Attachment #8669797 - Flags: review?(matt.woodrow)
Attachment #8669797 - Flags: review?(jwwang)
Attachment #8669797 - Flags: review+
Attachment #8669797 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8669797 [details]
MozReview Request: Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.

https://reviewboard.mozilla.org/r/21259/#review19267
Comment on attachment 8669797 [details]
MozReview Request: Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.

Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.
Rebase to currnet truck
Attachment #8669797 - Attachment description: MozReview Request: Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM; r?jwwang → MozReview Request: Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.
Attachment #8669797 - Flags: review?(jwwang)
Attachment #8669797 - Flags: review+
Comment on attachment 8669797 [details]
MozReview Request: Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.

Carry r+ from Comment 2 & 3.
Attachment #8669797 - Flags: review?(jwwang) → review+
I can't find a way to carry r+ by pushing MozReviewRequest ...
(In reply to Kilik Kuo [:kikuo][:kilikkuo] from comment #7)
> Try run, https://treeherder.mozilla.org/#/jobs?repo=try&revision=e96bda0d5de1

looks good !
Keywords: checkin-needed
https://reviewboard.mozilla.org/r/21259/#review19365

Try getting familiar with reviewboard ...
Carry r+ from mattwoodrow on MozReviewRequest and jwwang on Bug 1211364 Comment 2.
https://hg.mozilla.org/mozilla-central/rev/32227d966b60
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.