1211364 - Do MDSM::CheckFrameValidity() earlier when video frames arrive MDSM.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Kilik Kuo [:kikuo] (inactive)]

Currently MDSM checks frame validity in MDSM::RenderVideoFrame() and since we'd like to move the frame rendering logic out of MDSM (Bug 1194918 Comment 32), it would be better to check it earlier once video frames arrive MDSM, so that MDSM is able to decided whether turning off HW acceleration in advance if needed.

Comment 1

[Kilik Kuo [:kikuo] (inactive)]

Attachment: MozReview Request: Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.

Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM; r?jwwang

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8669797 [details]
MozReview Request: Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.

Looks fine to me. But I am not sure if there are concerns if we count corrupted frames when they arrive MDSM instead of when they are rendered.

But it surely fixes the problem bug 1196408 tried to fix where corrupted frames are counted multiple times.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8669797 [details]
MozReview Request: Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.

https://reviewboard.mozilla.org/r/21259/#review19267

Comment 4

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8669797 [details]
MozReview Request: Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.

Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.
Rebase to currnet truck

Comment 5

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8669797 [details]
MozReview Request: Bug 1211364 - Check frame validity earlier when decoded frames arrive in MDSM.

Carry r+ from Comment 2 & 3.

Comment 6

[Kilik Kuo [:kikuo] (inactive)]

I can't find a way to carry r+ by pushing MozReviewRequest ...

Comment 7

[Kilik Kuo [:kikuo] (inactive)]

Try run, https://treeherder.mozilla.org/#/jobs?repo=try&revision=e96bda0d5de1

Comment 8

[Kilik Kuo [:kikuo] (inactive)]

(In reply to Kilik Kuo [:kikuo][:kilikkuo] from comment #7)
> Try run, https://treeherder.mozilla.org/#/jobs?repo=try&revision=e96bda0d5de1

looks good !

Comment 9

[Kilik Kuo [:kikuo] (inactive)]

https://reviewboard.mozilla.org/r/21259/#review19365

Try getting familiar with reviewboard ...
Carry r+ from mattwoodrow on MozReviewRequest and jwwang on Bug 1211364 Comment 2.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32227d966b60

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/32227d966b60