1211365 - Remove wheel event handling for AccessibleCaretEventHub

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

All desktop platforms support APZ now. eWheelOperationStart and eWheelOperationEnd are superseded by AsyncPanZoomStarted and AsyncPanZoomStopped respectively. We can remove the wheel event handling in AccessibleCaretEventHub.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1211365 - Remove NS_IMPL_STATE_UTILITIES. r=mtseng

Bug 1211365 - Remove NS_IMPL_STATE_UTILITIES. r=mtseng

This macro was used to implement Name() and Singleton() for state
classes. Instead of enforcing the state class to be a singleton, we can
implement singleton pattern in MOZ_IMPL_STATE_CLASS_GETTER directly.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1211365 - Make deleted functions in class State public. r=mtseng

Bug 1211365 - Make deleted functions in class State public. r=mtseng

Compilers might generate better error messages. See Effective Modern C++
item 11.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1211365 - Add test case for scrolling in selection mode. r=mtseng

Bug 1211365 - Add test case for scrolling in selection mode. r=mtseng

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1211365 - Delete wheel event handling. r=mtseng

Bug 1211365 - Delete wheel event handling. r=mtseng

All desktop platforms support APZ now. eWheelOperationStart and
eWheelOperationEnd are superseded by AsyncPanZoomStarted and
AsyncPanZoomStopped respectively.

Comment 5

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8669560 [details]
MozReview Request: Bug 1211365 - Remove NS_IMPL_STATE_UTILITIES. r=mtseng

https://reviewboard.mozilla.org/r/21227/#review19211

Comment 6

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8669561 [details]
MozReview Request: Bug 1211365 - Make deleted functions in class State public. r=mtseng

https://reviewboard.mozilla.org/r/21229/#review19213

Comment 7

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8669562 [details]
MozReview Request: Bug 1211365 - Add test case for scrolling in selection mode. r=mtseng

https://reviewboard.mozilla.org/r/21231/#review19215

Comment 8

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8669563 [details]
MozReview Request: Bug 1211365 - Delete wheel event handling. r=mtseng

https://reviewboard.mozilla.org/r/21233/#review19217

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3654a2a0d28
https://hg.mozilla.org/integration/mozilla-inbound/rev/13045de2414d
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fa54b04cd60
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0865d36454c

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a3654a2a0d28
https://hg.mozilla.org/mozilla-central/rev/13045de2414d
https://hg.mozilla.org/mozilla-central/rev/4fa54b04cd60
https://hg.mozilla.org/mozilla-central/rev/f0865d36454c