Remove wheel event handling for AccessibleCaretEventHub

RESOLVED FIXED in Firefox 44

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

unspecified
mozilla44
Points:
---

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(4 attachments)

All desktop platforms support APZ now. eWheelOperationStart and eWheelOperationEnd are superseded by AsyncPanZoomStarted and AsyncPanZoomStopped respectively. We can remove the wheel event handling in AccessibleCaretEventHub.
Created attachment 8669560 [details]
MozReview Request: Bug 1211365 - Remove NS_IMPL_STATE_UTILITIES. r=mtseng

Bug 1211365 - Remove NS_IMPL_STATE_UTILITIES. r=mtseng

This macro was used to implement Name() and Singleton() for state
classes. Instead of enforcing the state class to be a singleton, we can
implement singleton pattern in MOZ_IMPL_STATE_CLASS_GETTER directly.
Attachment #8669560 - Flags: review?(mtseng)
Created attachment 8669561 [details]
MozReview Request: Bug 1211365 - Make deleted functions in class State public. r=mtseng

Bug 1211365 - Make deleted functions in class State public. r=mtseng

Compilers might generate better error messages. See Effective Modern C++
item 11.
Attachment #8669561 - Flags: review?(mtseng)
Created attachment 8669562 [details]
MozReview Request: Bug 1211365 - Add test case for scrolling in selection mode. r=mtseng

Bug 1211365 - Add test case for scrolling in selection mode. r=mtseng
Attachment #8669562 - Flags: review?(mtseng)
Created attachment 8669563 [details]
MozReview Request: Bug 1211365 - Delete wheel event handling. r=mtseng

Bug 1211365 - Delete wheel event handling. r=mtseng

All desktop platforms support APZ now. eWheelOperationStart and
eWheelOperationEnd are superseded by AsyncPanZoomStarted and
AsyncPanZoomStopped respectively.
Attachment #8669563 - Flags: review?(mtseng)
Comment on attachment 8669560 [details]
MozReview Request: Bug 1211365 - Remove NS_IMPL_STATE_UTILITIES. r=mtseng

https://reviewboard.mozilla.org/r/21227/#review19211
Attachment #8669560 - Flags: review?(mtseng) → review+
Comment on attachment 8669561 [details]
MozReview Request: Bug 1211365 - Make deleted functions in class State public. r=mtseng

https://reviewboard.mozilla.org/r/21229/#review19213
Attachment #8669561 - Flags: review?(mtseng) → review+
Comment on attachment 8669562 [details]
MozReview Request: Bug 1211365 - Add test case for scrolling in selection mode. r=mtseng

https://reviewboard.mozilla.org/r/21231/#review19215
Attachment #8669562 - Flags: review?(mtseng) → review+
Comment on attachment 8669563 [details]
MozReview Request: Bug 1211365 - Delete wheel event handling. r=mtseng

https://reviewboard.mozilla.org/r/21233/#review19217
Attachment #8669563 - Flags: review?(mtseng) → review+
You need to log in before you can comment on or make changes to this bug.