1211437 - Focus doesn't get set inside the Hello panel correctly the first time you open it (with the keyboard)

Status: RESOLVED INCOMPLETE

(Hello (Loop) :: Client, defect, P3)

Description

[:Gijs (he/him)]

I'm not really sure what causes this, but I expect there's some kind of race condition and/or incorrect assumption in the code that deals with loading content in the panel vs. short-circuiting that because the content is already loaded, which currently means that with the following steps:

0. Ensure Firefox is closed
1. Open Firefox
2. open the hello panel using: control-f2 (you might need "fn" on a macbook), t, down arrow, t again

ER:
focus is on something in the hello panel

AR:
focus is not on something in the hello panel

Mike, any chance you could help figure out what I'm missing?

Comment 1

[Mark Banner (:standard8)]

I just added a bit of debugging, and there's a Social:EnsureFocusElement message that gets fired once the panel is visible (in Loop's bootstrap.js in togglePanel).

I suspect that for the first time load, its being fired too soon, and should probably wait until a DOMContentLoaded has been fired.

We should probably also move the Social:EnsureFocusElement message firing into the openPanel function, as that gets called directly from other places, and if we're opening the panel we should be moving the focus aiui.

Comment 2

[Marco Zehe (:MarcoZ)]

Yep, we should do that. There's nothing more irritating to keyboard and screen reader users if one opens a panel, and focus doesn't get set there. Because if I open it, I usually want to interact with it, too.

Comment 3

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.