1211485 - Default search engine can still be set as default using the contextual menu

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Petruta Horea [:phorea], Desktop QA]

Attachment: same engine.png

Reproduced with Dev Edition 43.0a2 and Nightly 44.0a1 2015-10-04 across platforms.

Steps to reproduce:
1. Open the search toolbar panel
2. Change the default search engine using Ctrl/Cmd + Up/Down arrow
3. Right click on the search engine previously selected and click on "Set As Default Search Engine"

Actual results:
Nothing happens as that search engine was already set as default

Expected: Either one-click list is updated or the "Set As Default Search Engine" option from the contextual menu is grayed out for that engine

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: MozReview Request: Bug 1211485 - Disable set-as-default context menu item when the target engine is already the default. r=florian

Review commit: https://reviewboard.mozilla.org/r/39089/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39089/

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8728750 [details]
MozReview Request: Bug 1211485 - Disable set-as-default context menu item when the target engine is already the default. r=florian

https://reviewboard.mozilla.org/r/39089/#review35825

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

https://hg.mozilla.org/integration/fx-team/rev/947c1a6bee31e13736c8a6a6739ccdca3c641397
Bug 1211485 - Disable set-as-default context menu item when the target engine is already the default. r=florian

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/947c1a6bee31

Comment 5

[Aaron Raimist [:aaronraimist]]

Verified fixed in 2016-04-06 Firefox Nightly on Xubuntu Linux x86_64

Comment 6

[Cipri]

I reproduced the initial issue on Nightly 44.0a1 (2015-10-04).
I verified that the issue is fixed using Firefox 48.0b6 on Windows 10 x64, Ubuntu 14.04 x32, Mac 10.10.

Comment 7

[Bogdan Maris, Desktop QA]

Thanks Cipri! 
Changing the status flag for 48 to verified.