Closed Bug 1211485 Opened 4 years ago Closed 4 years ago
Default search engine can still be set as default using the contextual menu
Reproduced with Dev Edition 43.0a2 and Nightly 44.0a1 2015-10-04 across platforms. Steps to reproduce: 1. Open the search toolbar panel 2. Change the default search engine using Ctrl/Cmd + Up/Down arrow 3. Right click on the search engine previously selected and click on "Set As Default Search Engine" Actual results: Nothing happens as that search engine was already set as default Expected: Either one-click list is updated or the "Set As Default Search Engine" option from the contextual menu is grayed out for that engine
Review commit: https://reviewboard.mozilla.org/r/39089/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/39089/
Attachment #8728750 - Flags: review?(florian)
Comment on attachment 8728750 [details] MozReview Request: Bug 1211485 - Disable set-as-default context menu item when the target engine is already the default. r=florian https://reviewboard.mozilla.org/r/39089/#review35825
Attachment #8728750 - Flags: review?(florian) → review+
https://hg.mozilla.org/integration/fx-team/rev/947c1a6bee31e13736c8a6a6739ccdca3c641397 Bug 1211485 - Disable set-as-default context menu item when the target engine is already the default. r=florian
4 years ago
QA Whiteboard: [good first verify]
Verified fixed in 2016-04-06 Firefox Nightly on Xubuntu Linux x86_64
Status: RESOLVED → VERIFIED
QA Whiteboard: [good first verify] → [good first verify][bugday-20160406]
I reproduced the initial issue on Nightly 44.0a1 (2015-10-04). I verified that the issue is fixed using Firefox 48.0b6 on Windows 10 x64, Ubuntu 14.04 x32, Mac 10.10.
You need to log in before you can comment on or make changes to this bug.