Invite buttons should be underneath "Invite a friend" text in popped-out view

VERIFIED FIXED in Firefox 43

Status

Hello (Loop)
Client
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: sevaan, Assigned: Mardak)

Tracking

unspecified
mozilla44
Points:
2

Firefox Tracking Flags

(firefox43 verified, firefox44 verified)

Details

Attachments

(4 attachments)

(Reporter)

Description

2 years ago
Created attachment 8669810 [details]
Screenshot of Issue

When popping out the conversation window, the invitation buttons are separated by too much space from the "Invite a friend to join you" text.

The buttons should be underneath the buttons in the same manner of spacing as it looked when the conversation window is docked.
(Assignee)

Updated

2 years ago
Depends on: 1184924
(Assignee)

Comment 1

2 years ago
Created attachment 8669999 [details] [diff] [review]
v1
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #8669999 - Flags: review?(standard8)
(Assignee)

Comment 2

2 years ago
Created attachment 8670000 [details]
v1 screenshot
Attachment #8670000 - Flags: ui-review?(sfranks)
(Assignee)

Updated

2 years ago
Points: --- → 2
(Reporter)

Updated

2 years ago
Attachment #8670000 - Flags: ui-review?(sfranks) → ui-review+
Comment on attachment 8669999 [details] [diff] [review]
v1

Review of attachment 8669999 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=Standard8
Attachment #8669999 - Flags: review?(standard8) → review+
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/5e57563087b61888fb2e1551ab4a3fc4fb2ebecf
Bug 1211563 - Invite buttons should be underneath "Invite a friend" text in popped-out view [r=Standard8]
https://hg.mozilla.org/mozilla-central/rev/5e57563087b6
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
(Assignee)

Comment 6

2 years ago
Created attachment 8670939 [details] [diff] [review]
for aurora (Mardak will land)

Approval Request Comment
[Feature/regressing bug #]: Hello Visual refresh
[User impact if declined]: Buttons can be separated from the related header text on large windows
[Describe test coverage new/current, TreeHerder]: N/a, css only
[Risks and why]: Low - css only
[String/UUID change made/needed]: None

I'll land this after bug 1184924 is uplifted.
(Assignee)

Comment 7

2 years ago
Comment on attachment 8670939 [details] [diff] [review]
for aurora (Mardak will land)

Approval Request Comment
[Feature/regressing bug #]: Hello Visual refresh
[User impact if declined]: Buttons can be separated from the related header text on large windows
[Describe test coverage new/current, TreeHerder]: N/a, css only
[Risks and why]: Low - css only
[String/UUID change made/needed]: None

I'll land this after bug 1184924 is uplifted.
Attachment #8670939 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

2 years ago
Iteration: --- → 44.2 - Oct 19
Comment on attachment 8670939 [details] [diff] [review]
for aurora (Mardak will land)

Minor css tweaks, ok to uplift to aurora
Attachment #8670939 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 9

2 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/eeef206961d3
Bug 1211563 - Invite buttons should be underneath "Invite a friend" text in popped-out view [r=Standard8, a=lizzard]
status-firefox43: --- → fixed
Flags: qe-verify+
QA Contact: bogdan.maris
Verified that the buttons are underneath 'Invite a fiend' string just as shown in attachment using Firefox Developer Edition 43.0a2 and latest Nightly 44.0a1 across platforms (Windows 7 64-bit, Windows 10 64-bit, Mac OS X 10.11 and Ubuntu 14.04 32-bit).
Status: RESOLVED → VERIFIED
status-firefox43: fixed → verified
status-firefox44: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.