1211563 - Invite buttons should be underneath "Invite a friend" text in popped-out view

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Sevaan Franks [:sevaan]]

Attachment: Screenshot of Issue

When popping out the conversation window, the invitation buttons are separated by too much space from the "Invite a friend to join you" text.

The buttons should be underneath the buttons in the same manner of spacing as it looked when the conversation window is docked.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

Comment 2

[Ed Lee :Mardak]

Attachment: v1 screenshot

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8669999 [details] [diff] [review]
v1

Review of attachment 8669999 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=Standard8

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/integration/fx-team/rev/5e57563087b61888fb2e1551ab4a3fc4fb2ebecf
Bug 1211563 - Invite buttons should be underneath "Invite a friend" text in popped-out view [r=Standard8]

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5e57563087b6

Comment 6

[Ed Lee :Mardak]

Attachment: for aurora (Mardak will land)

Approval Request Comment
[Feature/regressing bug #]: Hello Visual refresh
[User impact if declined]: Buttons can be separated from the related header text on large windows
[Describe test coverage new/current, TreeHerder]: N/a, css only
[Risks and why]: Low - css only
[String/UUID change made/needed]: None

I'll land this after bug 1184924 is uplifted.

Comment 7

[Ed Lee :Mardak]

Comment on attachment 8670939 [details] [diff] [review]
for aurora (Mardak will land)

Approval Request Comment
[Feature/regressing bug #]: Hello Visual refresh
[User impact if declined]: Buttons can be separated from the related header text on large windows
[Describe test coverage new/current, TreeHerder]: N/a, css only
[Risks and why]: Low - css only
[String/UUID change made/needed]: None

I'll land this after bug 1184924 is uplifted.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8670939 [details] [diff] [review]
for aurora (Mardak will land)

Minor css tweaks, ok to uplift to aurora

Comment 9

[Ed Lee :Mardak]

http://hg.mozilla.org/releases/mozilla-aurora/rev/eeef206961d3
Bug 1211563 - Invite buttons should be underneath "Invite a friend" text in popped-out view [r=Standard8, a=lizzard]

Comment 10

[Bogdan Maris, Desktop Test Engineering]

Verified that the buttons are underneath 'Invite a fiend' string just as shown in attachment using Firefox Developer Edition 43.0a2 and latest Nightly 44.0a1 across platforms (Windows 7 64-bit, Windows 10 64-bit, Mac OS X 10.11 and Ubuntu 14.04 32-bit).