Closed Bug 1211642 Opened 5 years ago Closed 5 years ago

Whitelist test plugin for async init

Categories

(Core :: Plug-ins, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox42 --- wontfix
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

Attachments

(1 file)

We need to whitelist the test plugin to ensure that async init will be tested adequately.
Blocks: 1145838
Attached patch PatchSplinter Review
Attachment #8673315 - Flags: review?(jmathies)
Attachment #8673315 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/f02deaaeb828
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8673315 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: async plugin init
[User impact if declined]: async init will be disabled during testing
[Describe test coverage new/current, TreeHerder]: plugin test suite
[Risks and why]: Low, this really only affects testing but does affect xul.dll so I'm requesting approval.
[String/UUID change made/needed]: None
Attachment #8673315 - Flags: approval-mozilla-beta?
Attachment #8673315 - Flags: approval-mozilla-aurora?
Comment on attachment 8673315 [details] [diff] [review]
Patch

Taking anything to help testing async plugin init.
Should be in 42 beta 8
Attachment #8673315 - Flags: approval-mozilla-beta?
Attachment #8673315 - Flags: approval-mozilla-beta+
Attachment #8673315 - Flags: approval-mozilla-aurora?
Attachment #8673315 - Flags: approval-mozilla-aurora+
Too late for 42 (even more as we disabled async plugin init)
Attachment #8673315 - Flags: approval-mozilla-beta+ → approval-mozilla-beta-
(In reply to Wes Kocher (:KWierso) from comment #8)
> Various plugin tests have been failing since this landed on beta:
> https://treeherder.mozilla.org/logviewer.html#?job_id=588233&repo=mozilla-
> beta
> https://treeherder.mozilla.org/logviewer.html#?job_id=588229&repo=mozilla-
> beta
> https://treeherder.mozilla.org/logviewer.html#?job_id=588224&repo=mozilla-
> beta
> 
> 
> Backing out to fix them up:
> https://hg.mozilla.org/releases/mozilla-beta/rev/bff8b3d98f72

That's due to bug 1218473 et al. Will be sorted out with that.
Flags: needinfo?(aklotz)
You need to log in before you can comment on or make changes to this bug.