Closed Bug 1211722 Opened 6 years ago Closed 4 years ago

signed/unsigned comparison in pl_base64_decode_buffer

Categories

(NSS :: Libraries, defect, P2)

defect

Tracking

(firefox44 affected)

RESOLVED FIXED
Tracking Status
firefox44 --- affected

People

(Reporter: mt, Assigned: mt)

Details

Attachments

(1 file)

22:53:00     INFO -  nssb64d.c: In function 'pl_base64_decode_buffer':
 22:53:00    ERROR -  nssb64d.c:254:36: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
Attached patch bug1211722.patchSplinter Review
I'm not sure that this is the only one in here.  I'm concerned that there are others hiding in here.  But this is the best I can do until this is run on try again.
Attachment #8670014 - Flags: review?(kaie)
Comment on attachment 8670014 [details] [diff] [review]
bug1211722.patch

r=kaie
Attachment #8670014 - Flags: review?(kaie) → review+
Did we land this? Do we still want to?
Flags: needinfo?(martin.thomson)
Priority: -- → P2
Comment on attachment 8670014 [details] [diff] [review]
bug1211722.patch

Review of attachment 8670014 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/projects/nss/rev/96a835be15192281d67a8b1046b7f159ff6deb12
Attachment #8670014 - Flags: checked-in+
Thanks for the reminder.
Assignee: nobody → martin.thomson
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(martin.thomson)
Resolution: --- → FIXED
Target Milestone: --- → 3.34
You need to log in before you can comment on or make changes to this bug.