1211787 - Improve the accuracy of MediaDecoderStateMachine::GetDecodedAudioDuration()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

DedocdedStream doesn't remove the audio samples from the queue after sending them to the media stream. This results in an overestimation of the return value of GetDecodedAudioDuration().

This causes audio samples to be removed in a burst in DiscardStreamData() which happens about every 40ms and fluctuations in next frame status between NEXT_FRAME_AVAILABLE and NEXT_FRAME_UNAVAILABLE.

This also cause audio glitches more likely to happen because audio is not decoded steadily.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1908b7e73e1d

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1211787 - Improve the accuracy of MediaDecoderStateMachine::GetDecodedAudioDuration(). r=roc.

Bug 1211787 - Improve the accuracy of MediaDecoderStateMachine::GetDecodedAudioDuration(). r=roc.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8670629 [details]
MozReview Request: Bug 1211787 - Improve the accuracy of MediaDecoderStateMachine::GetDecodedAudioDuration(). r=roc.

https://reviewboard.mozilla.org/r/21419/#review19303

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/029c4ffba064

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/029c4ffba064