1211824 - nsPluginInstanceOwner shouldn't restrict to deliver native messages except preventing bugs of specific plugins

Status: RESOLVED WONTFIX

(Core Graveyard :: Plug-ins, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, we prevent to deliver some native messages which are sent by WidgetPluginEvent if the plugin is neither flash player nor test plugin. This means that the other plugins cannot support IME or something other features in windowless mode.

Unless we have reports of bugs of specific plugins, we should deliver all messages to all plugins.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=553b2e400cb3

Comment 2

[Benjamin Smedberg]

Please hold on this. We have an announcement about the future of plugin support later this week which may affect whether we want to do this.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Please hold on this. We have an announcement about the future of plugin
> support later this week which may affect whether we want to do this.

Hmm, even if we would support only Flash and/or something, the patch removes unnecessary check...
See https://hg.mozilla.org/try/rev/8a65b681fac1

So, anyway, I'd like to land that, how do you think?

Comment 4

[Benjamin Smedberg]

This will start delivering more native events to all plugins, right? I'm worried about the risk of existing plugins not being prepared to handle new event types causing weird behaviors or crashes.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> This will start delivering more native events to all plugins, right?

Yes.

> I'm worried about the risk of existing plugins not being prepared to handle new
> event types causing weird behaviors or crashes.

Understand. However, the messages are only WM_IME_* for now. And we need to do add WM_MOUSE*WHEEL at fixing bug 376679. So, I don't think that they cause crashes, but yes, they could cause not showing composing string since if nobody handles WM_IME_*, Windows will show composition string itself. However, the committed string won't be sent to windowless plugins too. So, at least for now, other plugins cannot work with IME in windowless mode. E.g., Silverlight forcibly works as windowed mode even if I append wmode="transparent".

Another option is, we should ignore the limitation only for WM_MOUSE*WHEEL, however, it causes messy code...

Comment 6

[Benjamin Smedberg]

To be clear, we should make whatever changes are necessary for Flash (and QA that they work properly). We should not deliver new events to non-Flash plugins unless we have adequate testing in place. The interface for all other plugins should be considered frozen and deprecated:

https://blog.mozilla.org/futurereleases/2015/10/08/npapi-plugins-in-firefox/

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Okay. I found another way to support wheel messages on windowless plugins. So, I don't need to touch around here for making the implementation simpler.