Closed
Bug 1211854
Opened 10 years ago
Closed 10 years ago
Rewrite CardsView as a PageRegion
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
()
Details
Attachments
(1 file)
Follow-up from bug 1211621. Initially I thought of doing it in that bug, but it turns out that it's more complicated that first thought.
I need to check these tests while trying to fix this:
http://mxr.mozilla.org/gaia/search?string=cardsview&find=.py
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8670223 [details] [review]
[gaia] mwargers:1211854 > mozilla-b2g:master
Like this. This also contains fixes for swipe_to_previous_app, because test_cards_view_with_two_apps.py was failing with it (although that test is currently not enabled for Flame due to memory).
Attachment #8670223 -
Flags: review?(npark)
Attachment #8670223 -
Flags: review?(jlorenzo)
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8670223 [details] [review]
[gaia] mwargers:1211854 > mozilla-b2g:master
the change seems pretty standard to me. r+
Attachment #8670223 -
Flags: review?(npark) → review+
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8670223 [details] [review]
[gaia] mwargers:1211854 > mozilla-b2g:master
A simple nit and a question left. They are not blockers to me.
Attachment #8670223 -
Flags: review?(jlorenzo) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•