Rewrite CardsView as a PageRegion

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: Martijn Wargers (dead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Follow-up from bug 1211621. Initially I thought of doing it in that bug, but it turns out that it's more complicated that first thought.

I need to check these tests while trying to fix this:
http://mxr.mozilla.org/gaia/search?string=cardsview&find=.py
Created attachment 8670223 [details] [review]
[gaia] mwargers:1211854 > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8670223 [details] [review]
[gaia] mwargers:1211854 > mozilla-b2g:master

Like this. This also contains fixes for swipe_to_previous_app, because test_cards_view_with_two_apps.py was failing with it (although that test is currently not enabled for Flame due to memory).
Attachment #8670223 - Flags: review?(npark)
Attachment #8670223 - Flags: review?(jlorenzo)
Comment on attachment 8670223 [details] [review]
[gaia] mwargers:1211854 > mozilla-b2g:master

the change seems pretty standard to me. r+
Attachment #8670223 - Flags: review?(npark) → review+
Comment on attachment 8670223 [details] [review]
[gaia] mwargers:1211854 > mozilla-b2g:master

A simple nit and a question left. They are not blockers to me.
Attachment #8670223 - Flags: review?(jlorenzo) → review+
(Assignee)

Comment 5

2 years ago
Merged: https://github.com/mozilla-b2g/gaia/commit/bba9c1788aeb6b88ec0a5c9306614a16653a6cc2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.