1211979 - Annotate crash reports triggered by MOZ_RELEASE_ASSERT in release builds

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

This is the logical next step after bug 1183355 - MOZ_RELEASE_ASSERT is in less use than MOZ_CRASH (git grep suggests ~1773 instances), but should also be annotated.

A few open questions remain, like whether MOZ_RELEASE_ASSERT should use MozCrashReason like MOZ_CRASH does, or if it should have its own field.

Comment 1

[(Away)]

Doesn't MOZ_RELEASE_ASSERT just forward to MOZ_CRASH under the hood?

Comment 2

[Nika Layzell [:nika] (ni? for response)]

(In reply to David Major [:dmajor] from comment #1)
> Doesn't MOZ_RELEASE_ASSERT just forward to MOZ_CRASH under the hood?

MOZ_RELEASE_ASSERT uses MOZ_REALLY_CRASH to trigger the crash, but doesn't actually call MOZ_CRASH. It uses it's own reporting mechanism: https://dxr.mozilla.org/mozilla-central/source/mfbt/Assertions.h?case=true&from=MOZ_RELEASE_ASSERT#358-374

We have to annotate it separately.

Comment 3

[(Away)]

Ah, that's unfortunate.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Annotate crashes triggered by MOZ_RELEASE_ASSERT

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e41c30798423

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/298e7602ddcd

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/298e7602ddcd