Closed Bug 1212037 Opened 9 years ago Closed 9 years ago

Create infrastructure for automated screenshots

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios 2.0+ ---

People

(Reporter: krudnitski, Assigned: fluffyemily)

References

Details

Attachments

(1 file, 1 obsolete file)

Pull request
48 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review 
We need to create infrastructure to let us make screenshots in an automated way. There are two clients for screenshots: marketing would like to make screenshots in many locales for the app store meta data and the L10N team would like to see screenshots of new functionality so that they can do a visual inspection of localized UI items.
Severity: enhancement → normal
OS: Other → iOS
Priority: P5 → --
Hardware: Other → All
Blocks: 1213016
Bulk changes to Aha cards. Filter on 'mpopova-aha-20151008' to find all matching messages.
tracking-fxios: --- → 2.0+
Assignee: nobody → etoop
Status: NEW → ASSIGNED
Blocks: 1217855
Attached file Pull request (obsolete) — 
Includes build-tools changes found at https://github.com/mozilla/firefox-ios-build-tools/pull/1

Note: This is adding the ability to do automated screenshots. There are problems with the screenshot tests, but those will be resolved in https://bugzilla.mozilla.org/show_bug.cgi?id=1205015
Attachment #8692520 - Flags: review?(sleroux)
Attachment #8692520 - Flags: review?(sarentz)
How is this PR different from https://github.com/mozilla/firefox-ios/pull/1310 ? It looks like there is a lot of overlap.
Flags: needinfo?(etoop)
Yeah, that's because it's a patch based off https://github.com/mozilla/firefox-ios/pull/1310 and so in a diff with master it looks the same. Maybe I should have raised the PR against the parent branch and not master so you could see the differences. Let me kill that PR and raise a new one.
Flags: needinfo?(etoop)
Attached file Pull request — 

  

  



        Attachment #8692520 -
        Attachment is obsolete: true

        Attachment #8692520 -
        Flags: review?(sleroux)

        Attachment #8692520 -
        Flags: review?(sarentz)

        Attachment #8693000 -
        Flags: review?(sleroux)

        Attachment #8693000 -
        Flags: review?(sarentz)

    
    

    
  
Includes PR against build tools: https://github.com/mozilla/firefox-ios-build-tools/pull/1

  

  



    
    

    
  
Comment on attachment 8693000 [details] [review]
Pull request

Good stuff. Lets land it and start using it.

  

  



        Attachment #8693000 -
        Flags: review?(sarentz) → review+

    
  
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

        Attachment #8693000 -
        Flags: review?(sleroux)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: