1212355 - [light devedition theme] No URLbar dropmarker visible on Linux

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[:Gijs (he/him)]

Looks like it uses urlbar-dropmarker-url which is only defined for the dark theme, and because Linux doesn't actually use this variable normally (ie there's no fallback definition) the image is just empty.

Comment 1

[Rakhi(:rakhisharma)]

Hey, Will you please elaborate more about it, what the bug actually is?

Comment 2

[:Gijs (he/him)]

(In reply to Rakhi(:rakhisharma) from comment #1)
> Hey, Will you please elaborate more about it, what the bug actually is?

Here's how to reproduce it with Nightly:

1) open nightly on linux
2) open the add-on manager (ctrl-shift-a)
3) click 'appearance'
4) enable the developer/devedition theme
5) open the web developer toolbox (ctrl-shift-k)
6) click the settings cog on the top right
7) under "Themes", switch to the 'light' theme
8) look in the URL bar, next to the stop/reload button, when the mouse hovers over the URL field. There should be a dropmarker (little arrow pointing down) just like in the default theme, but it's gone missing.

Does that help?

Comment 3

[Rakhi(:rakhisharma)]

Yeah, got it :) 
Please assign this to me.

Comment 4

[Rakhi(:rakhisharma)]

Attachment: MozReview Request: Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs

Review commit: https://reviewboard.mozilla.org/r/40623/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40623/

Comment 5

[:Gijs (he/him)]

Comment on attachment 8731465 [details]
MozReview Request: Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs

https://reviewboard.mozilla.org/r/40623/#review37237

Close, but not quite!

::: browser/themes/shared/devedition.inc.css:201
(Diff revision 1)
> +    --urlbar-dropmarker-url: url("chrome://browser/skin/devedition/urlbar-history-dropmarker.svg");
> +  --urlbar-dropmarker-region: rect(0px, 11px, 14px, 0px);
> +  --urlbar-dropmarker-hover-region: rect(0, 22px, 14px, 11px);
> +  --urlbar-dropmarker-active-region: rect(0px, 33px, 14px, 22px);
> +  --urlbar-dropmarker-2x-url: url("chrome://browser/skin/devedition/urlbar-history-dropmarker.svg");
> +  --urlbar-dropmarker-2x-region: rect(0px, 11px, 14px, 0px);
> +  --urlbar-dropmarker-hover-2x-region: rect(0, 22px, 14px, 11px);
> +  --urlbar-dropmarker-active-2x-region: rect(0px, 33px, 14px, 22px);

Instead of putting this here, can you put it in the linux-specific file, and create a rule specifically for :root[devtoolstheme="light"] at the top of the file? Then this won't change anything on the light versions of the theme on Windows and OS X, and it won't be superfluously set twice in the dark theme (because devedition.inc.css which you're changing here already sets exactly these values for the dark theme, right?)

PS: also make sure the properties all use a 2-space indent. :-)

Comment 6

[Rakhi(:rakhisharma)]

Attachment: MozReview Request: "Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs"

Review commit: https://reviewboard.mozilla.org/r/40759/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40759/

Comment 7

[Rakhi(:rakhisharma)]

Comment on attachment 8731465 [details]
MozReview Request: Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40623/diff/1-2/

Comment 8

[Rakhi(:rakhisharma)]

Comment on attachment 8731465 [details]
MozReview Request: Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40623/diff/2-3/

Comment 9

[:Gijs (he/him)]

Comment on attachment 8731465 [details]
MozReview Request: Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs

https://reviewboard.mozilla.org/r/40623/#review37611

Nice, thanks!

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88427e76ab56

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/88427e76ab56

Comment 12

[Nazir Ahmed Sabbir [:NaSb]]

I've managed to reproduce this bug on Firefox Developer Edition 43.0a2 (2015-10-07) ;
(Build ID: 20151007004048) on Linux, 64 Bit.

This Bug is now verified as fixed on Latest Firefox Developer Edition 48.0a2 (2016-05-11)

Build ID: 20160511004106
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
OS: Linux 3.19.0-58-generic x86-64