Closed
Bug 1212355
Opened 9 years ago
Closed 8 years ago
[light devedition theme] No URLbar dropmarker visible on Linux
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 48
People
(Reporter: Gijs, Assigned: rakhisharma, Mentored)
Details
Attachments
(1 file, 1 obsolete file)
Looks like it uses urlbar-dropmarker-url which is only defined for the dark theme, and because Linux doesn't actually use this variable normally (ie there's no fallback definition) the image is just empty.
Assignee | ||
Comment 1•8 years ago
|
||
Hey, Will you please elaborate more about it, what the bug actually is?
Flags: needinfo?(gijskruitbosch+bugs)
Reporter | ||
Comment 2•8 years ago
|
||
(In reply to Rakhi(:rakhisharma) from comment #1) > Hey, Will you please elaborate more about it, what the bug actually is? Here's how to reproduce it with Nightly: 1) open nightly on linux 2) open the add-on manager (ctrl-shift-a) 3) click 'appearance' 4) enable the developer/devedition theme 5) open the web developer toolbox (ctrl-shift-k) 6) click the settings cog on the top right 7) under "Themes", switch to the 'light' theme 8) look in the URL bar, next to the stop/reload button, when the mouse hovers over the URL field. There should be a dropmarker (little arrow pointing down) just like in the default theme, but it's gone missing. Does that help?
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(Rakhish1994)
Assignee | ||
Comment 3•8 years ago
|
||
Yeah, got it :) Please assign this to me.
Flags: needinfo?(Rakhish1994)
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → Rakhish1994
Mentor: gijskruitbosch+bugs
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40623/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40623/
Attachment #8731465 -
Flags: review?(gijskruitbosch+bugs)
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8731465 [details] MozReview Request: Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs https://reviewboard.mozilla.org/r/40623/#review37237 Close, but not quite! ::: browser/themes/shared/devedition.inc.css:201 (Diff revision 1) > + --urlbar-dropmarker-url: url("chrome://browser/skin/devedition/urlbar-history-dropmarker.svg"); > + --urlbar-dropmarker-region: rect(0px, 11px, 14px, 0px); > + --urlbar-dropmarker-hover-region: rect(0, 22px, 14px, 11px); > + --urlbar-dropmarker-active-region: rect(0px, 33px, 14px, 22px); > + --urlbar-dropmarker-2x-url: url("chrome://browser/skin/devedition/urlbar-history-dropmarker.svg"); > + --urlbar-dropmarker-2x-region: rect(0px, 11px, 14px, 0px); > + --urlbar-dropmarker-hover-2x-region: rect(0, 22px, 14px, 11px); > + --urlbar-dropmarker-active-2x-region: rect(0px, 33px, 14px, 22px); Instead of putting this here, can you put it in the linux-specific file, and create a rule specifically for :root[devtoolstheme="light"] at the top of the file? Then this won't change anything on the light versions of the theme on Windows and OS X, and it won't be superfluously set twice in the dark theme (because devedition.inc.css which you're changing here already sets exactly these values for the dark theme, right?) PS: also make sure the properties all use a 2-space indent. :-)
Attachment #8731465 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 6•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40759/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/40759/
Attachment #8731654 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8731465 [details] MozReview Request: Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40623/diff/1-2/
Attachment #8731465 -
Attachment description: MozReview Request: "Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs" → MozReview Request: Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs
Attachment #8731465 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Updated•8 years ago
|
Attachment #8731654 -
Attachment is obsolete: true
Attachment #8731654 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8731465 [details] MozReview Request: Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40623/diff/2-3/
Reporter | ||
Comment 9•8 years ago
|
||
Comment on attachment 8731465 [details] MozReview Request: Bug 1212355 - [light devedition theme] No URLbar dropmarker visible on Linux, r?gijs https://reviewboard.mozilla.org/r/40623/#review37611 Nice, thanks!
Attachment #8731465 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/88427e76ab56
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Comment 12•8 years ago
|
||
I've managed to reproduce this bug on Firefox Developer Edition 43.0a2 (2015-10-07) ; (Build ID: 20151007004048) on Linux, 64 Bit. This Bug is now verified as fixed on Latest Firefox Developer Edition 48.0a2 (2016-05-11) Build ID: 20160511004106 User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0 OS: Linux 3.19.0-58-generic x86-64
QA Whiteboard: [bugday-20160511]
Reporter | ||
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•