1212403 - [TV 2.5] Apply visual spec to the client-side page of TV remote control

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[Luke Chang [:lchang] (inactive)]

Apply visual spec to the client-side page of TV remote control.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1212403_remote_control_client_visual > mozilla-b2g:master

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8684844 [details] [review]
[gaia] luke-chang:1212403_remote_control_client_visual > mozilla-b2g:master

Hi Rex,

Could you please have a look at this patch?

Please refer to [1] for the Visual Spec. Besides, I modified a few behaviors on PIN-Code input fields due to compatibility issues on various browsers.

Thanks.

[1] http://bit.ly/1jrWQU3

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8684844 [details] [review]
[gaia] luke-chang:1212403_remote_control_client_visual > mozilla-b2g:master

r=me!

Comment 4

[Luke Chang [:lchang] (inactive)]

Rex, Thanks for your review.


tests passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=c010e247fe3784656ba40011661e2898a98b99e8

landed on master: https://github.com/mozilla-b2g/gaia/commit/e6e6b3ab3bcf04431300d5c472f89771380baa02

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8684844 [details] [review]
[gaia] luke-chang:1212403_remote_control_client_visual > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1205939 [meta] TV Remote Control.
[User impact] if declined: Remote Control feature on TV isn't completed.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): Low risk since this patch only affect TV build.
[String changes made]: Yes, but TV team will take care of this.

Comment 6

[Gabriele Svelto [:gsvelto]]

I've just noticed that the icons that were introduced with this commit have not been compressed. They take over a MB of space whereas they should only take ~1KB each. Please run the compression script in the gaia tools and commit the compressed images instead (you'll need the optipng and advancecomp/advpng packages installed). From the gaia root directory execute the following command:

./tools/png_recompress.sh -v \
    tv_apps/remote-control-client/style/images/btn_back.png \
    tv_apps/remote-control-client/style/images/btn_home.png \
    tv_apps/remote-control-client/style/images/btn_option.png \
    tv_apps/remote-control-client/style/images/scrollbar.png

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] mozilla-b2g:revert-33067-1212403_remote_control_client_visual > mozilla-b2g:master

Comment 8

[Luke Chang [:lchang] (inactive)]

Hi Gabriele,

Thanks for your reminder.

I've backout'ed my patch: https://github.com/mozilla-b2g/gaia/commit/feccab8e9e326ff999852a63a269fdbb2dbb311a

And will re-land it with compressed images.

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:1212403_remote_control_client_visual > mozilla-b2g:master

Comment 10

[Luke Chang [:lchang] (inactive)]

Re-landed: https://github.com/mozilla-b2g/gaia/commit/4e95ab738ba8428198587fa7ee339943152f4fa2

Comment 11

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8687523 [details] [review]
[gaia] luke-chang:1212403_remote_control_client_visual > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1205939 [meta] TV Remote Control.
[User impact] if declined: Remote Control feature on TV isn't completed.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): Low risk since this patch only affect TV build.
[String changes made]: Yes, but TV team will take care of this.

Comment 12

[Josh Cheng [:josh]]

Approve as required for TV 2.5

Comment 13

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/c9aa052db624d657e47cd7b494299397cf72b719