1212437 - Port back/forward button styling cleanup from bug 1173744 to Linux

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[:Gijs (he/him)]

Attachment: Gaps around the back/fwd button

I see gaps around the back button (more visible on lwtheme, but the borders of the fwd button don't connect up properly in the normal theme like this, either).

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch v2

Comment 3

[:Gijs (he/him)]

Comment on attachment 8671482 [details] [diff] [review]
patch v2

Review of attachment 8671482 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/linux/browser.css
@@ +697,5 @@
>    margin-bottom: 3px;
>  }
>  
> +:-moz-any(#back-button, #forward-button) > .toolbarbutton-icon {
> +  border-color: ThreeDShadow !important;

Ugh. Can you add a comment why we need the import (ie to override the .toolbarbutton1 version of this rule for navbar/tabstoolbar, AFAICT) ?

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/adad5316300f

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/adad5316300f

Comment 6

[Dão Gottwald [:dao]]

Possible performance improvement from this patch:

Fx-Team-Non-PGO - Talos Page Switch - Ubuntu HW 12.04 x64 - 4.11% decrease