Closed
Bug 1212469
Opened 9 years ago
Closed 9 years ago
Make oomTest() a shell function to help the fuzzers
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
14.40 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
4.74 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
As requested, this is preferable since otherwise you need to load a library to get this function.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jcoppeard
Assignee | ||
Comment 1•9 years ago
|
||
Patch to implement this.
This shows up some more failures on armsim builds which I'm investigating.
Assignee | ||
Comment 2•9 years ago
|
||
Patch to reimplement oomTest() as a shell function. It should be more deterministic like this too.
Attachment #8671823 -
Attachment is obsolete: true
Attachment #8671924 -
Flags: review?(nicolas.b.pierron)
Assignee | ||
Comment 3•9 years ago
|
||
Patch to fix a couple of issues that started showing up with the previous patch.
The first is that compilerOutputs vector in the TypeZone can end up with containing a script that we failed to link if we get an OOM after FinishCompilation() in LazyLink(). This causes an assert on subsequent calls to LazyLink() for the same script.
The second is that IonCompile() could leave a script's ionScript set to ION_COMPILING_SCRIPT if StartOffThreadIonCompile() failed.
Attachment #8671927 -
Flags: review?(jdemooij)
Comment 4•9 years ago
|
||
Comment on attachment 8671927 [details] [diff] [review]
ion-fixes-for-shell-oomTest
Review of attachment 8671927 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jit/Ion.cpp
@@ -2207,5 @@
>
> // If possible, compile the script off thread.
> if (options.offThreadCompilationAvailable()) {
> - if (!recompile)
> - builderScript->setIonScript(cx, ION_COMPILING_SCRIPT);
Hannes fixed this one in another bug so it may already be on inbound when this lands.
Attachment #8671927 -
Flags: review?(jdemooij) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8671924 [details] [diff] [review]
bug1212469-shell-oomTest v2
Review of attachment 8671924 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/builtin/TestingFunctions.cpp
@@ +56,5 @@
> static bool
> +EnvVarIsDefined(const char* name)
> +{
> + const char* value = getenv(name);
> + return value && value[0] != '0';
nit: && !*value
Attachment #8671924 -
Flags: review?(nicolas.b.pierron) → review+
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9c365490d4ce
https://hg.mozilla.org/mozilla-central/rev/46cd97a3b2e6
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•