1212510 - Bustage fix: Rename NS_ParseContentType to NS_ParseResponseContentType (caused by Bug 1210302)

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Comment 1

[Philip Chee]

Attachment: Patch s/NS_ParseContentType/NS_ParseResponseContentType/

> You are not authorized to access bug 1210302.
:P

Comment 2

[(no longer active)]

Comment on attachment 8670952 [details] [diff] [review]
Patch s/NS_ParseContentType/NS_ParseResponseContentType/

I don't know this code, sorry.

Comment 3

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8670952 [details] [diff] [review]
Patch s/NS_ParseContentType/NS_ParseResponseContentType/

Review of attachment 8670952 [details] [diff] [review]:
-----------------------------------------------------------------

Without revealing the purpose of the changes in bug 1210302, I will say that this patch is safe because the implementations here are implementations of nsIChannel::SetContentType, and the changed code would be equivalent to nsBaseChannel::SetContentType. Bug 1210302 does raise other questions, but I think there are no changes needed to Thunderbird code as a result.

Comment 4

[Kent James (:rkent)]

Comment on attachment 8670952 [details] [diff] [review]
Patch s/NS_ParseContentType/NS_ParseResponseContentType/

https://hg.mozilla.org/comm-central/rev/5d74f3155ba2

Comment 5

[Kent James (:rkent)]

Thanks for the fix! Pushing now since this is a blocker.

Comment 6

[Edmund Wong (:ewong)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/adae4392080b was pushed, so
we're busted in c-a as well.

Comment 7

[Edmund Wong (:ewong)]

Comment on attachment 8670952 [details] [diff] [review]
Patch s/NS_ParseContentType/NS_ParseResponseContentType/

[Approval Request Comment]
Regression caused by (bug #): 1210302
User impact if declined: cannot build
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):

Comment 8

[Edmund Wong (:ewong)]

Comment on attachment 8670952 [details] [diff] [review]
Patch s/NS_ParseContentType/NS_ParseResponseContentType/

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on c-c, etc.): 
Risk to taking this patch (and alternatives if risky):

Comment 9

[Edmund Wong (:ewong)]

(In reply to Edmund Wong (:ewong) from comment #8)
> Comment on attachment 8670952 [details] [diff] [review]
> Patch s/NS_ParseContentType/NS_ParseResponseContentType/
> 
> [Approval Request Comment]
> Regression caused by (bug #): 
> User impact if declined: 
> Testing completed (on c-c, etc.): 
> Risk to taking this patch (and alternatives if risky):

It was also pushed to m-b.

Comment 10

[Magnus Melin [:mkmelin]]

Status tracks the trunk status. Use flags for branch tracking.

Comment 11

[Kent James (:rkent)]

Comment on attachment 8670952 [details] [diff] [review]
Patch s/NS_ParseContentType/NS_ParseResponseContentType/

https://hg.mozilla.org/releases/comm-beta/rev/b9438b2ca19c
https://hg.mozilla.org/releases/comm-aurora/rev/ff104068062a

Comment 12

[Kent James (:rkent)]

The patch forcing these changes will be pushed to mozilla-esr38, but the current plans are to do that in an esr-safe manner that does not require this patch.