Closed Bug 1212528 Opened 6 years ago Closed 6 years ago

[AccessFu] Ensure that first document ancestor is first in utterance if present in ancestry.

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
feature-b2g 2.2r+
Tracking Status
firefox44 --- fixed
b2g-v2.2r --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

Attachments

(2 files, 1 obsolete file)

We should get rid of an option for switching between 2 types of order and just use one where ancestry is announced first.
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
What we actually want is to give context (document/dialog) right away, before presenting the actual virtual cursor position. The result of this improvement, the user will first hear the document utterance and then virtual cursor pivot context.

Example:

Before:
* Current page heading level one, Calendar

After:
* Calendar, Current page heading level one
Summary: [AccessFu] Switch utterance order to top ancestor first. → [AccessFu] Ensure that first document ancestor is first in utterance if present in ancestry.
Attached patch 1212528 patchSplinter Review
Will open a separate bug for ignoring context when closing dialog.
Attachment #8673706 - Flags: review?(mzehe)
Attachment #8673706 - Flags: review?(mzehe) → review+
https://hg.mozilla.org/mozilla-central/rev/8fbe5948f1fa
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Comment on attachment 8673706 [details] [diff] [review]
1212528 patch

Review of attachment 8673706 [details] [diff] [review]:
-----------------------------------------------------------------

This is a dependent for bug 1209062 which is scheduled for 2.2r.
Attachment #8673706 - Flags: approval‑mozilla‑b2g37_v2_2r?
feature-b2g: --- → 2.2r+
Keywords: checkin-needed
According to the release management planning on 2.2R[1], approval should be auto granted because 2.2R isn't FL yet.

https://wiki.mozilla.org/Release_Management/FirefoxOS/2_2_R_Schedule#Patch_Uplifts
failed to apply to 2.2r 

applying 1212528.patch
patching file accessible/tests/mochitest/jsat/test_content_integration.html
Hunk #2 FAILED at 73
Hunk #3 FAILED at 100
Hunk #4 FAILED at 137
3 out of 4 hunks FAILED -- saving rejects to file accessible/tests/mochitest/jsat/test_content_integration.html.rej
Flags: needinfo?(yzenevich)
Keywords: checkin-needed
Attached patch 1212528 patch for b2g37_v2_2r (obsolete) — Splinter Review
Flags: needinfo?(yzenevich)
(In reply to Yura Zenevich [:yzen] from comment #9)
> Created attachment 8675721 [details] [diff] [review]
> 1212528 patch for b2g37_v2_2r

Hi, this failed to apply with :

patching file accessible/jsat/OutputGenerator.jsm
Hunk #1 FAILED at 67
1 out of 1 hunks FAILED -- saving rejects to file accessible/jsat/OutputGenerator.jsm.rej
patching file accessible/tests/mochitest/jsat/test_content_integration.html
Hunk #1 FAILED at 26
1 out of 5 hunks FAILED -- saving rejects to file accessible/tests/mochitest/jsat/test_content_integration.html.rej
patching file accessible/tests/mochitest/jsat/test_content_text.html
Hunk #1 FAILED at 25
1 out of 1 hunks FAILED -- saving rejects to file accessible/tests/mochitest/jsat/test_content_text.html.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh 1212528.b2g37_v2_2r.patch
(In reply to Carsten Book [:Tomcat] from comment #10)
> (In reply to Yura Zenevich [:yzen] from comment #9)
> > Created attachment 8675721 [details] [diff] [review]
> > 1212528 patch for b2g37_v2_2r
> 
> Hi, this failed to apply with :
> 
> patching file accessible/jsat/OutputGenerator.jsm
> Hunk #1 FAILED at 67
> 1 out of 1 hunks FAILED -- saving rejects to file
> accessible/jsat/OutputGenerator.jsm.rej
> patching file accessible/tests/mochitest/jsat/test_content_integration.html
> Hunk #1 FAILED at 26
> 1 out of 5 hunks FAILED -- saving rejects to file
> accessible/tests/mochitest/jsat/test_content_integration.html.rej
> patching file accessible/tests/mochitest/jsat/test_content_text.html
> Hunk #1 FAILED at 25
> 1 out of 1 hunks FAILED -- saving rejects to file
> accessible/tests/mochitest/jsat/test_content_text.html.rej
> patch failed, unable to continue (try -v)
> patch failed, rejects left in working directory
> errors during apply, please fix and refresh 1212528.b2g37_v2_2r.patch

Im not sure how this is possible. The patch part at least for OutputGenerator.jsm is exactly the same as the one that was attempted to be applied previously. But in the initial attempt it looked like it applied. Same goes for test_content_text.html ...
:Tomcat, would you know how i can check out b2g37_v2_2r locally from hg to try to apply the patch. I've been only able to do that with git mirror (https://github.com/mozilla/gecko-dev/tree/b2g37_v2_2r)
Flags: needinfo?(cbook)
(In reply to Carsten Book [:Tomcat] from comment #13)
> Hey Yura, v2.2r is http://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/
> 
> so hg clone http://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/ should work
> :)

OK, though I don't think it's any different from my previous patch. But it definitely applies for me locally to an up to date clone of http://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/
Attachment #8675721 - Attachment is obsolete: true
interesting seems there was really a problem with my local repo. thanks yura, pushed this now as https://hg.mozilla.org/releases/mozilla-b2g37_v2_2r/rev/b26683793614
Comment on attachment 8673706 [details] [diff] [review]
1212528 patch

Review of attachment 8673706 [details] [diff] [review]:
-----------------------------------------------------------------

Removing since it's landed in 2.2r
Attachment #8673706 - Flags: approval‑mozilla‑b2g37_v2_2r?
You need to log in before you can comment on or make changes to this bug.