Closed Bug 1212542 Opened 4 years ago Closed 4 years ago

Integrate raptor-regression into raptor-cli

Categories

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S4 - 1/1

People

(Reporter: Eli, Assigned: Eli)

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

Need to refactor to support only passing and returning of data, as raptor-cli is the interface for all CLI operations. Also experimenting with a new functional style.
I know we walked through the changes I made, but I'd still like to get your stamp on this. :)
Attachment #8670977 - Flags: review?(rwood)
Comment on attachment 8670977 [details] [review]
Link to Github pull-request: https://github.com/mozilla-raptor/regression/pull/4

This is really cool! I'm still getting my head around some of it, but it LGTM. A couple of comments in the PR.
Attachment #8670977 - Flags: review?(rwood) → review+
mozilla-raptor/regression in master: https://github.com/mozilla-raptor/regression/commit/b82512be2d772d730a2602c13f300bad15a16f09

mozilla-raptor/regression in npm: 1.0.0
Target Milestone: FxOS-S9 (16Oct) → 2.6 S3 - 12/18
Attachment #8696978 - Flags: review?(rwood)
Comment on attachment 8696978 [details] [review]
PR: https://github.com/mozilla-raptor/regression/pull/7

Code LGTM. Piped a few raptor queries into raptor regression and it ran; didn't retest actually finding a real regression as we already proved the regression detection algorithm in the past.
Attachment #8696978 - Flags: review?(rwood) → review+
In master: https://github.com/mozilla-raptor/regression/commit/1daf77af3f45a902506d728d68a5f37acb20e699

Leaving open until I do the npm publishing.
In npm: raptor-regression@2.0.0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: 2.6 S3 - 12/18 → 2.6 S4 - 1/1
You need to log in before you can comment on or make changes to this bug.