1212542 - Integrate raptor-regression into raptor-cli

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Description

[:Eli Perelman]

Need to refactor to support only passing and returning of data, as raptor-cli is the interface for all CLI operations. Also experimenting with a new functional style.

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-raptor/regression/pull/4

I know we walked through the changes I made, but I'd still like to get your stamp on this. :)

Comment 2

[Robert Wood [:rwood]]

Comment on attachment 8670977 [details] [review]
Link to Github pull-request: https://github.com/mozilla-raptor/regression/pull/4

This is really cool! I'm still getting my head around some of it, but it LGTM. A couple of comments in the PR.

Comment 3

[:Eli Perelman]

mozilla-raptor/regression in master: https://github.com/mozilla-raptor/regression/commit/b82512be2d772d730a2602c13f300bad15a16f09

mozilla-raptor/regression in npm: 1.0.0

Comment 4

[:Eli Perelman]

Attachment: PR: https://github.com/mozilla-raptor/regression/pull/7

Comment 5

[Robert Wood [:rwood]]

Comment on attachment 8696978 [details] [review]
PR: https://github.com/mozilla-raptor/regression/pull/7

Code LGTM. Piped a few raptor queries into raptor regression and it ran; didn't retest actually finding a real regression as we already proved the regression detection algorithm in the past.

Comment 6

[:Eli Perelman]

In master: https://github.com/mozilla-raptor/regression/commit/1daf77af3f45a902506d728d68a5f37acb20e699

Leaving open until I do the npm publishing.

Comment 7

[:Eli Perelman]

In npm: raptor-regression@2.0.0