Status
People
(Reporter: Eli, Assigned: Eli)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
(Whiteboard: [systemsfe])
Attachments
(2 attachments)
|
46 bytes,
text/x-github-pull-request
|
rwood
:
review+
|
Details | Review | Splinter Review |
|
46 bytes,
text/x-github-pull-request
|
rwood
:
review+
|
Details | Review | Splinter Review |
Allow making queries to an InfluxDB datasource via the CLI through use of the raptor-query module.
|
(Assignee) | |
Comment 1•3 years ago
|
||
Created attachment 8696976 [details] [review] PR: https://github.com/mozilla-raptor/query/pull/1
Attachment #8696976 -
Flags: review?(rwood)
|
||
Comment 2•3 years ago
|
||
Comment on attachment 8696976 [details] [review] PR: https://github.com/mozilla-raptor/query/pull/1 R+ on condition that your .raptorrc patch lands in the CLI, so that query works with .raptorrc settings: https://gist.githubusercontent.com/eliperelman/e3c12a83a92e820d8b8a/raw/ff69e4395441f738ded7c25e78bb55ba5017989a/file.patch
Attachment #8696976 -
Flags: review?(rwood) → review+
|
|
(Assignee) | |
Comment 3•3 years ago
|
||
RC config patch landed.
|
|
(Assignee) | |
Comment 4•3 years ago
|
||
First PR in master: https://github.com/mozilla-raptor/query/commit/23fcd813b0c52be350f7491bd316f7d6782a10dc
|
|
(Assignee) | |
Comment 5•3 years ago
|
||
Created attachment 8699062 [details] [review] PR: https://github.com/mozilla-raptor/query/pull/2 Follow-up patch to make required parameter validation better.
Attachment #8699062 -
Flags: review?(rwood)
|
|
||
Comment 6•3 years ago
|
||
Comment on attachment 8699062 [details] [review] PR: https://github.com/mozilla-raptor/query/pull/2 LGTM and works great
Attachment #8699062 -
Flags: review?(rwood) → review+
|
|
(Assignee) | |
Comment 7•3 years ago
|
||
Second PR in master: https://github.com/mozilla-raptor/query/commit/71588d09bec05f4c83f661934dc84b637534d056 Leaving open until I do the npm publishing.
|
|
(Assignee) | |
Comment 8•3 years ago
|
||
In npm: raptor-query@4.0.0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: FxOS-S9 (16Oct) → 2.6 S4 - 1/1
You need to log in
before you can comment on or make changes to this bug.
Description
•