Closed Bug 1212579 Opened 5 years ago Closed 5 years ago

Integrate raptor-query into raptor-cli

Categories

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::PerformanceTest
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.6 S4 - 1/1

People

(Reporter: Eli, Assigned: Eli)

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

PR: https://github.com/mozilla-raptor/query/pull/1
46 bytes, text/x-github-pull-request
rwood
: review+
Details | Review
PR: https://github.com/mozilla-raptor/query/pull/2
46 bytes, text/x-github-pull-request
rwood
: review+
Details | Review 
Allow making queries to an InfluxDB datasource via the CLI through use of the raptor-query module.
Attachment #8696976 - Flags: review?(rwood)
Comment on attachment 8696976 [details] [review]
PR: https://github.com/mozilla-raptor/query/pull/1

R+ on condition that your .raptorrc patch lands in the CLI, so that query works with .raptorrc settings:

https://gist.githubusercontent.com/eliperelman/e3c12a83a92e820d8b8a/raw/ff69e4395441f738ded7c25e78bb55ba5017989a/file.patch
Attachment #8696976 - Flags: review?(rwood) → review+
RC config patch landed.
Follow-up patch to make required parameter validation better.
Attachment #8699062 - Flags: review?(rwood)
Comment on attachment 8699062 [details] [review]
PR: https://github.com/mozilla-raptor/query/pull/2

LGTM and works great
Attachment #8699062 - Flags: review?(rwood) → review+
Second PR in master: https://github.com/mozilla-raptor/query/commit/71588d09bec05f4c83f661934dc84b637534d056

Leaving open until I do the npm publishing.
In npm: raptor-query@4.0.0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: FxOS-S9 (16Oct) → 2.6 S4 - 1/1
You need to log in before you can comment on or make changes to this bug.