Closed Bug 1212592 Opened 5 years ago Closed 5 years ago

[raptor-cli] Modularize CLI interfaces

Categories

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.6 S4 - 1/1

People

(Reporter: Eli, Assigned: Eli)

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

Right now all the commands and the functions they map to are in one big bin file. We need to split this up as more commands are coming and the file is too big already.
Target Milestone: FxOS-S8 (02Oct) → 2.6 S3 - 12/18
With no .raptorrc:

rwood@ubuntu:~/cli$ raptor --version
TypeError: Cannot read property 'config' of null
    at /home/rwood/cli/lib/extensions/rc.js:12:23
'raptor regression' on it's own (with no stdin) hangs
(In reply to Robert Wood [:rwood] from comment #3)
> 'raptor regression' on it's own (with no stdin) hangs

Same for the others that are expecting stdind ('raptor query', 'raptor bug')
(In reply to Robert Wood [:rwood] from comment #4)
> (In reply to Robert Wood [:rwood] from comment #3)
> > 'raptor regression' on it's own (with no stdin) hangs
> 
> Same for the others that are expecting stdind ('raptor query', 'raptor bug')

Correction: 'raptor track', and 'raptor bug'
(In reply to Robert Wood [:rwood] from comment #5)
> (In reply to Robert Wood [:rwood] from comment #4)
> > (In reply to Robert Wood [:rwood] from comment #3)
> > > 'raptor regression' on it's own (with no stdin) hangs
> > 
> > Same for the others that are expecting stdind ('raptor query', 'raptor bug')
> 
> Correction: 'raptor track', and 'raptor bug'

Fixed with latest update, i.e:

rwood@ubuntu:~/cli$ raptor regression
Error: Using this method requires stdin, no stdin detected
    at cli.stdin.Promise (/home/rwood/cli/lib/extensions/stdin.js:12:29)
Comment on attachment 8696973 [details]
Link to Github branch: https://github.com/mozilla-raptor/cli

With the latest updates (and our walk-throughs on irc & vidyo), ship it!
Attachment #8696973 - Flags: review?(rwood) → review+
In npm: @mozilla/raptor@5.0.0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: 2.6 S3 - 12/18 → 2.6 S4 - 1/1
You need to log in before you can comment on or make changes to this bug.