Closed
Bug 1212610
Opened 9 years ago
Closed 9 years ago
Unable to sort Sites in Permission dialogs
Categories
(Firefox :: Settings UI, defect)
Tracking
()
VERIFIED
FIXED
Firefox 44
Tracking | Status | |
---|---|---|
firefox41 | --- | unaffected |
firefox42 | + | verified |
firefox43 | --- | verified |
firefox44 | --- | verified |
People
(Reporter: pdehaan, Assigned: MattN)
References
Details
(Keywords: regression)
Attachments
(1 file)
40 bytes,
text/x-review-board-request
|
jaws
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details |
Found in 44.0.a1 (2015-10-06) # Steps to reproduce: 1. Go to `about:preferences#content` and click the [Choose...] button for Notifications. 2. Add a bunch of URLs manually (unless you have a populated list). 3. Sort by Status a few times. List should smartly group by "Allow" and "Block" as expected. 4. Sort by Site a few times. # Actual results: Cannot sort by Site. I imagine this would be frustrating if I was trying to block a previously allowed site because I didn't wish to receive notifications anymore for whatever reasons. # Expected results: I should be able to sort by "Site". I don't know how that should work. Should it ignore "http:" and "https:" and just sort on domain name? How should it handle "bing.com" versus "www.bing.com"? I imagine the last two should be grouped and "www." should be ignored, otherwise I may have to do a lot of hunting to find all instances of *.buzfeed.com in my permissions list.
Reporter | ||
Comment 1•9 years ago
|
||
Found in Mac OS X 10.11 (El Capitan), but also able to reproduce on Windows 10.
Assignee | ||
Comment 2•9 years ago
|
||
[Tracking Requested - why for this release]: regression in 42. This is a regression from bug 1173523, part 5: http://hg.mozilla.org/mozilla-central/rev/64a004bb6207 A reference to rawHost in permissions.xul should have been updated to `origin`.
Assignee: nobody → MattN+bmo
Blocks: 1173523
Status: NEW → ASSIGNED
status-firefox41:
--- → unaffected
status-firefox42:
--- → affected
status-firefox43:
--- → affected
tracking-firefox42:
--- → ?
Keywords: regression
Assignee | ||
Updated•9 years ago
|
Component: Notifications and Alerts → Preferences
Product: Toolkit → Firefox
Summary: Unable to sort Sites in Notification Permissions dialog (in Nightly) → Unable to sort Sites in Permission dialogs
Assignee | ||
Comment 3•9 years ago
|
||
Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws A reference to `rawHost` wasn't updated to `origin`.
Attachment #8675967 -
Flags: review?(jaws)
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8675967 [details] MozReview Request: Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws A reference to `rawHost` wasn't updated to `origin`.
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8675967 [details] MozReview Request: Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws Approval Request Comment [Feature/regressing bug #]: bug 1173523 regression [User impact if declined]: Cannot sort permission dialogs by the "Site" column [Describe test coverage new/current, TreeHerder]: browser-chrome test [Risks and why]: Low risk returning to past behaviour. This code was already run upon dialog load but not when the heading was clicked (instead there was an error in the console). [String/UUID change made/needed]: None
Attachment #8675967 -
Flags: approval-mozilla-beta?
Attachment #8675967 -
Flags: approval-mozilla-aurora?
Comment 6•9 years ago
|
||
Comment on attachment 8675967 [details] MozReview Request: Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws https://reviewboard.mozilla.org/r/22533/#review20243
Attachment #8675967 -
Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/d0b65ea82348
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Comment 10•9 years ago
|
||
Comment on attachment 8675967 [details] MozReview Request: Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws Has a good tests, regression introduced in 42, Mattn & jaws are usually fast at fixing regressions, taking it. Should be 42 beta 9.
Attachment #8675967 -
Flags: approval-mozilla-beta?
Attachment #8675967 -
Flags: approval-mozilla-beta+
Attachment #8675967 -
Flags: approval-mozilla-aurora?
Attachment #8675967 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
Flags: qe-verify+
Comment 13•9 years ago
|
||
I've tested on Windows 7 64bit and Mac OSX 10.11: - using latest Nightly 44.0a1 (buildID: 20151025030428) - I have a populated list and I'm able to sort by "Site" - using latest Aurora 43.0a2 (buildID: 20151026004023) and Firefox 42 Beta 9 (buildID: 20151022152545) - under Content from "about:preferences" page I don't have the Notifications subcategory to check this bug - it is ok? it is expected?
Flags: needinfo?(MattN+bmo)
Assignee | ||
Comment 14•9 years ago
|
||
This applies to all permission dialogs of that type e.g. popup exceptions, add-on installation exceptions, cookie exceptions.
Flags: needinfo?(MattN+bmo)
Comment 15•9 years ago
|
||
Thank you! Verified fixed using Firefox 42 RC (buildID: 20151026170526), latest Aurora 43.0a2 (buildID: 20151027004102) and latest Nightly 44.0a1 (buildID: 20151027030239).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•