1212610 - Unable to sort Sites in Permission dialogs

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Peter deHaan [:pdehaan]]

Found in 44.0.a1 (2015-10-06)

# Steps to reproduce:
1. Go to `about:preferences#content` and click the [Choose...] button for Notifications.
2. Add a bunch of URLs manually (unless you have a populated list).
3. Sort by Status a few times. List should smartly group by "Allow" and "Block" as expected.
4. Sort by Site a few times.

# Actual results:
Cannot sort by Site.
I imagine this would be frustrating if I was trying to block a previously allowed site because I didn't wish to receive notifications anymore for whatever reasons.

# Expected results:
I should be able to sort by "Site".
I don't know how that should work. Should it ignore "http:" and "https:" and just sort on domain name? How should it handle "bing.com" versus "www.bing.com"? I imagine the last two should be grouped and "www." should be ignored, otherwise I may have to do a lot of hunting to find all instances of *.buzfeed.com in my permissions list.

Comment 1

[Peter deHaan [:pdehaan]]

Found in Mac OS X 10.11 (El Capitan), but also able to reproduce on Windows 10.

Comment 2

[Matthew N. [:MattN]]

[Tracking Requested - why for this release]: regression in 42.

This is a regression from bug 1173523, part 5: http://hg.mozilla.org/mozilla-central/rev/64a004bb6207

A reference to rawHost in permissions.xul should have been updated to `origin`.

Comment 3

[Matthew N. [:MattN]]

Attachment: MozReview Request: Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws

Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws

A reference to `rawHost` wasn't updated to `origin`.

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8675967 [details]
MozReview Request: Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws

Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws

A reference to `rawHost` wasn't updated to `origin`.

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8675967 [details]
MozReview Request: Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws

Approval Request Comment
[Feature/regressing bug #]: bug 1173523 regression
[User impact if declined]: Cannot sort permission dialogs by the "Site" column
[Describe test coverage new/current, TreeHerder]: browser-chrome test
[Risks and why]: Low risk returning to past behaviour. This code was already run upon dialog load but not when the heading was clicked (instead there was an error in the console).
[String/UUID change made/needed]: None

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8675967 [details]
MozReview Request: Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws

https://reviewboard.mozilla.org/r/22533/#review20243

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d0b65ea82348

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Tracking as we will probably take that in 42 beta 9.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d0b65ea82348

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8675967 [details]
MozReview Request: Bug 1212610 - Fix sorting permissions by site due a legacy property name being referenced. r=jaws

Has a good tests, regression introduced in 42, Mattn & jaws are usually fast at fixing regressions, taking it. Should be 42 beta 9.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9ef311abacc4

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f23031e5a290

Comment 13

[Camelia Badau [:cbadau], Desktop QA]

I've tested on Windows 7 64bit and Mac OSX 10.11: 
- using latest Nightly 44.0a1 (buildID: 20151025030428) - I have a populated list and I'm able to sort by "Site"
- using latest Aurora 43.0a2 (buildID: 20151026004023) and Firefox 42 Beta 9 (buildID: 20151022152545) - under Content from "about:preferences" page I don't have the Notifications subcategory to check this bug - it is ok? it is expected?

Comment 14

[Matthew N. [:MattN]]

This applies to all permission dialogs of that type e.g. popup exceptions, add-on installation exceptions, cookie exceptions.

Comment 15

[Camelia Badau [:cbadau], Desktop QA]

Thank you! 

Verified fixed using Firefox 42 RC (buildID: 20151026170526), latest Aurora 43.0a2 (buildID: 20151027004102) and latest Nightly 44.0a1 (buildID: 20151027030239).