1212623 - --locale parameter no longer works with gaiatest

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

When I use the parameter --locale= for gaiatest command, it complains as below:
usage: gaiatest [options] test_file_or_dir <test_file_or_dir> ...
gaiatest: error: argument --locale: ignored explicit argument 'ar'

Usage is as below:
(2.5)MacBookPro:gaia-ui-tests mozilla$ gaiatest --address=localhost:2828 --testvars=gaiatest/b2g-7.json --type b2g --locale="ar" --restart --store-reference-image gaiatest/tests/graphics/RTL/test_settings_storage_RTL.py

I believe below commit may have caused this failure.  

https://github.com/mozilla-b2g/gaia/commit/05138cf77627d9fd3ad9f961750dc6317d938d1f#diff-aa53c37daef3296bf1dda16026719d7d

Comment 1

[No-Jun Park [:njpark]]

pyang, could you take a look at whether this is the case?  Thanks!

Comment 2

[Paul Yang [:pyang] (away)]

Sure, I'll see this one.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] zapion:bug1212623 > mozilla-b2g:master

Comment 4

[Paul Yang [:pyang] (away)]

Comment on attachment 8671221 [details] [review]
[gaia] zapion:bug1212623 > mozilla-b2g:master

Extra action added for locale option.
Remove it and work in my local.

Comment 5

[Martijn Wargers (dead)]

Comment on attachment 8671221 [details] [review]
[gaia] zapion:bug1212623 > mozilla-b2g:master

I don't really know this code, but if that makes it work, then I guess it's fine.
Note that --help also broke (see bug 1212796 ).
Ideally, we would have some automated testing around this to make sure this doesn't break again.

Comment 6

[No-Jun Park [:njpark]]

Comment on attachment 8671221 [details] [review]
[gaia] zapion:bug1212623 > mozilla-b2g:master

+1 about the need for automated testing on gaiatest itself. wonder whether marionette-js already has something that we can use.

Comment 7

[Paul Yang [:pyang] (away)]

(In reply to No-Jun Park [:njpark] from comment #6)
> Comment on attachment 8671221 [details] [review]
> [gaia] zapion:bug1212623 > mozilla-b2g:master
> 
> +1 about the need for automated testing on gaiatest itself. wonder whether
> marionette-js already has something that we can use.

This bug is a mis-use for action which indicates it should take no argument.  marionette client itself has unit test already and I doubt there is any for js version.

Comment 8

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/7ddc2ccdbc47ada8d73f8725655f7c0056c9f058