--locale parameter no longer works with gaiatest

RESOLVED FIXED in FxOS-S9 (16Oct)

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: njpark, Assigned: pyang)

Tracking

unspecified
FxOS-S9 (16Oct)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
njpark
: review+
Martijn Wargers (dead)
: review+
Details | Review | Splinter Review
(Reporter)

Description

2 years ago
When I use the parameter --locale= for gaiatest command, it complains as below:
usage: gaiatest [options] test_file_or_dir <test_file_or_dir> ...
gaiatest: error: argument --locale: ignored explicit argument 'ar'

Usage is as below:
(2.5)MacBookPro:gaia-ui-tests mozilla$ gaiatest --address=localhost:2828 --testvars=gaiatest/b2g-7.json --type b2g --locale="ar" --restart --store-reference-image gaiatest/tests/graphics/RTL/test_settings_storage_RTL.py

I believe below commit may have caused this failure.  

https://github.com/mozilla-b2g/gaia/commit/05138cf77627d9fd3ad9f961750dc6317d938d1f#diff-aa53c37daef3296bf1dda16026719d7d
(Reporter)

Updated

2 years ago
Component: Gaia::Video → Gaia::UI Tests
(Reporter)

Comment 1

2 years ago
pyang, could you take a look at whether this is the case?  Thanks!
Flags: needinfo?(pyang)
(Assignee)

Comment 2

2 years ago
Sure, I'll see this one.
Assignee: nobody → pyang
Flags: needinfo?(pyang)

Comment 3

2 years ago
Created attachment 8671221 [details] [review]
[gaia] zapion:bug1212623 > mozilla-b2g:master
(Assignee)

Comment 4

2 years ago
Comment on attachment 8671221 [details] [review]
[gaia] zapion:bug1212623 > mozilla-b2g:master

Extra action added for locale option.
Remove it and work in my local.
Attachment #8671221 - Flags: review?(npark)
Attachment #8671221 - Flags: review?(martijn.martijn)

Updated

2 years ago
Blocks: 1196489
Comment on attachment 8671221 [details] [review]
[gaia] zapion:bug1212623 > mozilla-b2g:master

I don't really know this code, but if that makes it work, then I guess it's fine.
Note that --help also broke (see bug 1212796 ).
Ideally, we would have some automated testing around this to make sure this doesn't break again.
Attachment #8671221 - Flags: review?(martijn.martijn) → review+
(Reporter)

Comment 6

2 years ago
Comment on attachment 8671221 [details] [review]
[gaia] zapion:bug1212623 > mozilla-b2g:master

+1 about the need for automated testing on gaiatest itself. wonder whether marionette-js already has something that we can use.
Attachment #8671221 - Flags: review?(npark) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 7

2 years ago
(In reply to No-Jun Park [:njpark] from comment #6)
> Comment on attachment 8671221 [details] [review]
> [gaia] zapion:bug1212623 > mozilla-b2g:master
> 
> +1 about the need for automated testing on gaiatest itself. wonder whether
> marionette-js already has something that we can use.

This bug is a mis-use for action which indicates it should take no argument.  marionette client itself has unit test already and I doubt there is any for js version.
https://github.com/mozilla-b2g/gaia/commit/7ddc2ccdbc47ada8d73f8725655f7c0056c9f058
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

Updated

2 years ago
Target Milestone: --- → FxOS-S9 (16Oct)
You need to log in before you can comment on or make changes to this bug.