Closed
Bug 1212656
Opened 9 years ago
Closed 9 years ago
ARM64: Fix automation build errors
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: sstangl, Assigned: sstangl)
References
Details
Attachments
(1 file)
4.33 KB,
patch
|
efaust
:
review+
|
Details | Diff | Splinter Review |
As efaust recently discovered on treeherder, apparently the automation ARM64 builds are not equivalent to FILES_PER_UNIFIED_FILE=1 builds.
The attached patch fixes build errors (and AsmJS warnings) that crop up when running "js/src/devtools/automation/autospider.sh arm64-sim".
efaust: Please feel free to land this on my behalf (or just fold it in with Bug 1185106).
Attachment #8671075 -
Flags: review?(efaustbmo)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → sstangl
Comment 1•9 years ago
|
||
Comment on attachment 8671075 [details] [diff] [review]
0001-Fix-obj-spider-ARM64-build-errors.patch
Review of attachment 8671075 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM. I'll land.
Attachment #8671075 -
Flags: review?(efaustbmo) → review+
Comment 3•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•