Closed Bug 1212689 Opened 6 years ago Closed 5 years ago

Extract ToolboxButtons from toolbox.js

Categories

(DevTools :: Framework, defect)

defect
Not set
normal

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: jryans, Assigned: jryans)

Details

Attachments

(1 file)

GCLI's commands/index.js loads toolbox.js to get at the buttons definitions.

This has the side effect of loading gDevTools.jsm inside the child process, among other terrible things.

We should extract the buttons to a separate module so GCLI can have what it needs without side effects.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8800434 [details]
Bug 1212689 - Extract ToolboxButtons to save GCLI from loading toolbox.js.

https://reviewboard.mozilla.org/r/85340/#review84120

Oh! Thanks for spotting and fixing this.
Attachment #8800434 - Flags: review?(poirot.alex) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f08d2842a62
Extract ToolboxButtons to save GCLI from loading toolbox.js. r=ochameau
https://hg.mozilla.org/mozilla-central/rev/8f08d2842a62
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.