Closed Bug 1212689 Opened 6 years ago Closed 5 years ago
Buttons from toolbox .js
58 bytes, text/x-review-board-request
GCLI's commands/index.js loads toolbox.js to get at the buttons definitions. This has the side effect of loading gDevTools.jsm inside the child process, among other terrible things. We should extract the buttons to a separate module so GCLI can have what it needs without side effects.
5 years ago
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8800434 [details] Bug 1212689 - Extract ToolboxButtons to save GCLI from loading toolbox.js. https://reviewboard.mozilla.org/r/85340/#review84120 Oh! Thanks for spotting and fixing this.
Attachment #8800434 - Flags: review?(poirot.alex) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8f08d2842a62 Extract ToolboxButtons to save GCLI from loading toolbox.js. r=ochameau
You need to log in before you can comment on or make changes to this bug.