Extract ToolboxButtons from toolbox.js

RESOLVED FIXED in Firefox 52

Status

()

Firefox
Developer Tools: Framework
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: jryans, Assigned: jryans)

Tracking

unspecified
Firefox 52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

GCLI's commands/index.js loads toolbox.js to get at the buttons definitions.

This has the side effect of loading gDevTools.jsm inside the child process, among other terrible things.

We should extract the buttons to a separate module so GCLI can have what it needs without side effects.
(Assignee)

Updated

2 years ago
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8800434 [details]
Bug 1212689 - Extract ToolboxButtons to save GCLI from loading toolbox.js.

https://reviewboard.mozilla.org/r/85340/#review84120

Oh! Thanks for spotting and fixing this.
Attachment #8800434 - Flags: review?(poirot.alex) → review+

Comment 4

2 years ago
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f08d2842a62
Extract ToolboxButtons to save GCLI from loading toolbox.js. r=ochameau

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8f08d2842a62
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.