Closed
Bug 1212689
Opened 9 years ago
Closed 8 years ago
Extract ToolboxButtons from toolbox.js
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
Details
Attachments
(1 file)
GCLI's commands/index.js loads toolbox.js to get at the buttons definitions. This has the side effect of loading gDevTools.jsm inside the child process, among other terrible things. We should extract the buttons to a separate module so GCLI can have what it needs without side effects.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a56ba358f450b613b5e3cbdcdb209b9253397ba
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8800434 [details] Bug 1212689 - Extract ToolboxButtons to save GCLI from loading toolbox.js. https://reviewboard.mozilla.org/r/85340/#review84120 Oh! Thanks for spotting and fixing this.
Attachment #8800434 -
Flags: review?(poirot.alex) → review+
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8f08d2842a62 Extract ToolboxButtons to save GCLI from loading toolbox.js. r=ochameau
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8f08d2842a62
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•