1212689 - Extract ToolboxButtons from toolbox.js

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

GCLI's commands/index.js loads toolbox.js to get at the buttons definitions.

This has the side effect of loading gDevTools.jsm inside the child process, among other terrible things.

We should extract the buttons to a separate module so GCLI can have what it needs without side effects.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1212689 - Extract ToolboxButtons to save GCLI from loading toolbox.js.

Review commit: https://reviewboard.mozilla.org/r/85340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/85340/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a56ba358f450b613b5e3cbdcdb209b9253397ba

Comment 3

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Comment on attachment 8800434 [details]
Bug 1212689 - Extract ToolboxButtons to save GCLI from loading toolbox.js.

https://reviewboard.mozilla.org/r/85340/#review84120

Oh! Thanks for spotting and fixing this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f08d2842a62
Extract ToolboxButtons to save GCLI from loading toolbox.js. r=ochameau

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8f08d2842a62