1212732 - Update caret in cursor mode on scroll-end if it was logically visible

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Currently, the caret in cursor mode is always hide after scrolling. I
think it's better to restore its appearance if it was logically visible
before scrolling.

We should write a gtest to cover this.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: MozReview Request: Bug 1212732 - Update caret in cursor mode on scroll-end if it was logically visible. r=roc

Bug 1212732 - Update caret in cursor mode on scroll-end if it was logically visible. r=roc

Currently, the caret in cursor mode is always hide after scrolling. I
think it's better to restore its appearance if it's logically visible
before scrolling. That is:

1) If the caret is logically visible (Normal or NormalNotShown) before
scrolling, update carets on scroll-end to show the caret again.
2) If the caret is hide due to timeout or blur, it should remain hidden
on scroll-end.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8671189 [details]
MozReview Request: Bug 1212732 - Update caret in cursor mode on scroll-end if it was logically visible. r=roc

https://reviewboard.mozilla.org/r/21555/#review19375

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

roc, thank you for the review.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/793fcff5028b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/793fcff5028b