Closed Bug 1212732 Opened 4 years ago Closed 4 years ago

Update caret in cursor mode on scroll-end if it was logically visible

Categories

(Core :: DOM: Selection, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently, the caret in cursor mode is always hide after scrolling. I
think it's better to restore its appearance if it was logically visible
before scrolling.

We should write a gtest to cover this.
Bug 1212732 - Update caret in cursor mode on scroll-end if it was logically visible. r=roc

Currently, the caret in cursor mode is always hide after scrolling. I
think it's better to restore its appearance if it's logically visible
before scrolling. That is:

1) If the caret is logically visible (Normal or NormalNotShown) before
scrolling, update carets on scroll-end to show the caret again.
2) If the caret is hide due to timeout or blur, it should remain hidden
on scroll-end.
Attachment #8671189 - Flags: review?(roc)
Comment on attachment 8671189 [details]
MozReview Request: Bug 1212732 - Update caret in cursor mode on scroll-end if it was logically visible. r=roc

https://reviewboard.mozilla.org/r/21555/#review19375
Attachment #8671189 - Flags: review?(roc) → review+
roc, thank you for the review.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/793fcff5028b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.