1212743 - sendMessage requires synchronous response

Status: RESOLVED INVALID

(WebExtensions :: Untriaged, defect)

Description

[Dale Harvey (:daleharvey)]

I have an addon that calls

    chrome.runtime.sendMessage(json, function (response) {
      console.log(response);
    });

It is handled basically like: 

    chrome.runtime.onMessage.addListener(function (req, sender, respond) { 
      var response = localSorage['things'];
      respond(response);
    });

However if I try to switch to chrome.storage (that has an async api, or even if I just

    chrome.runtime.onMessage.addListener(function (req, sender, respond) { 
      var response = localSorage['things'];
      setTimeout(function() { 
        respond(response)
      });
    });

Then the called never gets the response

Comment 1

[Dale Harvey (:daleharvey)]

Fabrice if you know who would be good to get this in front of it would be useful, cheers, ill stop bothering you shortly when I have more of an idea who else is working on the addon stuff

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Please read the docs for onMessage.
https://developer.chrome.com/extensions/runtime#event-onMessage
You need to |return true| from it if you want to respond asynchronously.

Comment 3

[Dale Harvey (:daleharvey)]

Awesome thanks, apologies for missing that