Closed Bug 1212853 Opened 6 years ago Closed 6 years ago

l10n repacks fail to "mozmake unpack" on windows

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(3 files)

06:37:07     INFO - Downloading https://queue.taskcluster.net/v1/task/Z0owUioXRRajd29eTkpoJQ/artifacts/public/build/firefox-42.0.en-US.win32.installer.exe to c:\builds\moz2_slave\rel-date_firefox_w32_l10n_rpk-\build\date\obj-l10n\dist\firefox-42.0.en-US.win32.installer.exe
06:37:07     INFO - retry: Calling _download_file with args: ('https://queue.taskcluster.net/v1/task/Z0owUioXRRajd29eTkpoJQ/artifacts/public/build/firefox-42.0.en-US.win32.installer.exe', 'c:\\builds\\moz2_slave\\rel-date_firefox_w32_l10n_rpk-\\build\\date\\obj-l10n\\dist\\firefox-42.0.en-US.win32.installer.exe'), kwargs: {}, attempt #1
06:37:10     INFO - Downloaded 43335656 bytes.
06:37:10     INFO - Running command: ['c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/mozmake.exe', 'unpack'] in c:\builds\moz2_slave\rel-date_firefox_w32_l10n_rpk-\build\date\obj-l10n\browser/locales
06:37:10     INFO - Copy/paste: c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/mozmake.exe unpack
06:37:10     INFO - Using env: {'ALLUSERSPROFILE': 'C:\\ProgramData',
06:37:10     INFO -  'APPDATA': 'C:\\Users\\cltbld\\AppData\\Roaming',
06:37:10     INFO -  'APR_ICONV_PATH': 'c:/mozilla-build/svn-win32-1.6.3/iconv',
06:37:10     INFO -  'BINSCOPE': 'C:\\Program Files (x86)\\Microsoft\\SDL BinScope\\BinScope.exe',
06:37:10     INFO -  'BUILDBOT_PATH': 'C:\\mozilla-build\\buildbotve',
06:37:10     INFO -  'COMMONPROGRAMFILES': 'C:\\Program Files (x86)\\Common Files',
06:37:10     INFO -  'COMMONPROGRAMFILES(X86)': 'C:\\Program Files (x86)\\Common Files',
06:37:10     INFO -  'COMMONPROGRAMW6432': 'C:\\Program Files\\Common Files',
06:37:10     INFO -  'COMPUTERNAME': 'B-2008-IX-0110',
06:37:10     INFO -  'COMSPEC': 'C:\\windows\\system32\\cmd.exe',
06:37:10     INFO -  'CVS_RSH': 'ssh',
06:37:10     INFO -  'DCLOCATION': 'SCL3',
06:37:10     INFO -  'DIST': 'c:\\builds\\moz2_slave\\rel-date_firefox_w32_l10n_rpk-\\build\\date\\obj-l10n',
06:37:10     INFO -  'DNSSUFFIX': 'winbuild.releng.scl3.mozilla.com',
06:37:10     INFO -  'DXSDK_DIR': 'C:\\Tools\\sdks\\dx10\\',
06:37:10     INFO -  'EDITOR': 'emacs.exe --no-window-system',
06:37:10     INFO -  'EN_US_BINARY_URL': 'https://queue.taskcluster.net/v1/task/Z0owUioXRRajd29eTkpoJQ/artifacts/public/build/firefox-42.0.en-US.win32.installer.exe',
06:37:10     INFO -  'FP_NO_HOST_CHECK': 'NO',
06:37:10     INFO -  'GIT_SHARE_BASE_DIR': 'C:/mozilla-build/msys/builds/git-shared',
06:37:10     INFO -  'HG_SHARE_BASE_DIR': 'c:/builds/hg-shared',
06:37:10     INFO -  'HOME': 'c:/Users/cltbld',
06:37:10     INFO -  'HOMEDRIVE': 'C:',
06:37:10     INFO -  'HOMEPATH': '\\',
06:37:10     INFO -  'HOSTTYPE': 'i686',
06:37:10     INFO -  'INPUTRC': 'C:/mozilla-build/msys/etc/inputrc',
06:37:10     INFO -  'IS_NIGHTLY': 'yes',
06:37:10     INFO -  'KTS_HOME': 'C:\\Program Files\\KTS',
06:37:10     INFO -  'KTS_VERSION': '1.19c',
06:37:10     INFO -  'L10NBASEDIR': '../../l10n',
06:37:10     INFO -  'LOCALAPPDATA': 'C:\\Users\\cltbld\\AppData\\Local',
06:37:10     INFO -  'LOCALE_MERGEDIR': 'c:\\builds\\moz2_slave\\rel-date_firefox_w32_l10n_rpk-\\build\\date\\obj-l10n\\merged/',
06:37:10     INFO -  'LOG': '"c:\\tmp\\buildbot-startup.log"',
06:37:10     INFO -  'LOGNAME': 'cltbld',
06:37:10     INFO -  'LOGONSERVER': '\\\\B-2008-IX-0110',
06:37:10     INFO -  'MACHTYPE': 'i686-pc-msys',
06:37:10     INFO -  'MAKE_MODE': 'unix',
06:37:10     INFO -  'MAR': 'c:\\\\\\\\builds\\\\\\\\moz2_slave\\\\\\\\rel-date_firefox_w32_l10n_rpk-\\\\\\\\build\\\\\\\\date\\\\\\\\obj-l10n\\\\\\\\dist\\\\\\\\host\\\\\\\\bin\\\\\\\\mar.exe',
06:37:10     INFO -  'MBSDIFF': 'c:\\\\\\\\builds\\\\\\\\moz2_slave\\\\\\\\rel-date_firefox_w32_l10n_rpk-\\\\\\\\build\\\\\\\\date\\\\\\\\obj-l10n\\\\\\\\dist\\\\\\\\host\\\\\\\\bin\\\\\\\\mbsdiff.exe',
06:37:10     INFO -  'MOZBUILDDIR': 'C:\\mozilla-build',
06:37:10     INFO -  'MOZILLABUILD': 'C:\\mozilla-build',
06:37:10     INFO -  'MOZ_AUTOMATION': '1',
06:37:10     INFO -  'MOZ_CRASHREPORTER_NO_REPORT': '1',
06:37:10     INFO -  'MOZ_MAKE_COMPLETE_MAR': '1',
06:37:10     INFO -  'MOZ_OBJDIR': 'obj-l10n',
06:37:10     INFO -  'MOZ_SIGNING_SERVERS': 'gpg:sha2signcode:osslsigncode:signcode:mar:jar:b2gmar:emevoucher:signing4.srv.releng.scl3.mozilla.com:9110,gpg:sha2signcode:osslsigncode:signcode:mar:jar:b2gmar:emevoucher:signing5.srv.releng.scl3.mozilla.com:9110,gpg:sha2signcode:osslsigncode:signcode:mar:jar:b2gmar:emevoucher:signing6.srv.releng.scl3.mozilla.com:9110,dmgv2:mac-v2-signing1.srv.releng.scl3.mozilla.com:9110,dmgv2:mac-v2-signing2.srv.releng.scl3.mozilla.com:9110,dmgv2:mac-v2-signing3.srv.releng.scl3.mozilla.com:9110,dmgv2:mac-v2-signing4.srv.releng.scl3.mozilla.com:9110,dmgv2:mac-v2-signing6.srv.releng.scl3.mozilla.com:9110,dmgv2:mac-v2-signing7.srv.releng.scl3.mozilla.com:9110',
06:37:10     INFO -  'MOZ_SIGN_CMD': 'python c:\\\\\\\\builds\\\\\\\\moz2_slave\\\\\\\\rel-date_firefox_w32_l10n_rpk-\\\\\\\\build\\\\\\\\tools\\\\\\\\release\\\\\\\\signing\\\\\\\\signtool.py --cachedir c:\\\\\\\\builds\\\\\\\\moz2_slave\\\\\\\\rel-date_firefox_w32_l10n_rpk-\\\\\\\\build\\\\\\\\signing_cache -t c:\\\\\\\\builds\\\\\\\\moz2_slave\\\\\\\\rel-date_firefox_w32_l10n_rpk-\\\\\\\\token -n c:\\\\\\\\builds\\\\\\\\moz2_slave\\\\\\\\rel-date_firefox_w32_l10n_rpk-\\\\\\\\nonce -c c:\\\\\\\\builds\\\\\\\\moz2_slave\\\\\\\\rel-date_firefox_w32_l10n_rpk-\\\\\\\\build\\\\\\\\tools\\\\\\\\release\\\\\\\\signing\\\\\\\\host.cert -H gpg:sha2signcode:osslsigncode:signcode:mar:jar:b2gmar:emevoucher:signing4.srv.releng.scl3.mozilla.com:9110 -H gpg:sha2signcode:osslsigncode:signcode:mar:jar:b2gmar:emevoucher:signing5.srv.releng.scl3.mozilla.com:9110 -H gpg:sha2signcode:osslsigncode:signcode:mar:jar:b2gmar:emevoucher:signing6.srv.releng.scl3.mozilla.com:9110 -H dmgv2:mac-v2-signing1.srv.releng.scl3.mozilla.com:9110 -H dmgv2:mac-v2-signing2.srv.releng.scl3.mozilla.com:9110 -H dmgv2:mac-v2-signing3.srv.releng.scl3.mozilla.com:9110 -H dmgv2:mac-v2-signing4.srv.releng.scl3.mozilla.com:9110 -H dmgv2:mac-v2-signing6.srv.releng.scl3.mozilla.com:9110 -H dmgv2:mac-v2-signing7.srv.releng.scl3.mozilla.com:9110',
06:37:10     INFO -  'MOZ_SYMBOLS_EXTRA_BUILDID': 'date',
06:37:10     INFO -  'MOZ_TOOLS': 'C:\\mozilla-build\\moztools-x64',
06:37:10     INFO -  'MOZ_UPDATE_CHANNEL': 'beta',
06:37:10     INFO -  'MSYSTEM': 'MINGW32',
06:37:10     INFO -  'NUMBER_OF_PROCESSORS': '4',
06:37:10     INFO -  'OLDPWD': 'c:/Users/cltbld',
06:37:10     INFO -  'OS': 'Windows_NT',
06:37:10     INFO -  'OSTYPE': 'msys',
06:37:10     INFO -  'PATH': 'C:\\mozilla-buildnsis-3.0b1;C:\\mozilla-buildnsis-2.46u;C:\\mozilla-buildpython27;C:\\mozilla-buildbuildbotve\\scripts;C:\\mozilla-build\\msys\\local\\bin;c:\\mozilla-build\\wget;c:\\mozilla-build\\7zip;c:\\mozilla-build\\blat261\\full;c:\\mozilla-build\\python;c:\\mozilla-build\\svn-win32-1.6.3\\bin;c:\\mozilla-build\\upx203w;c:\\mozilla-build\\emacs-22.3\\bin;c:\\mozilla-build\\info-zip;c:\\mozilla-build\\nsis-2.22;c:\\mozilla-build\\nsis-2.33u;c:\\mozilla-build\\nsis-2.46u;c:\\mozilla-build\\wix-351728;c:\\mozilla-build\\hg;c:\\mozilla-build\\python\\Scripts;c:\\mozilla-build\\kdiff3;c:\\mozilla-build\\yasm;.;C:\\mozilla-build\\msys\\local\\bin;C:\\mozilla-build\\msys\\mingw\\bin;C:\\mozilla-build\\msys\\bin;c:\\mozilla-build\\python27;c:\\mozilla-build\\buildbotve\\Scripts;c:\\Program Files (x86)\\Puppet Labs\\Puppet\\puppet\\bin;c:\\Program Files (x86)\\Puppet Labs\\Puppet\\facter\\bin;c:\\Program Files (x86)\\Puppet Labs\\Puppet\\hiera\\bin;c:\\Program Files (x86)\\Puppet Labs\\Puppet\\bin;c:\\Program Files (x86)\\Puppet Labs\\Puppet\\sys\\ruby\\bin;c:\\Program Files (x86)\\Puppet Labs\\Puppet\\sys\\tools\\bin;.;C:\\mozilla-build\\msys\\local\\bin;C:\\mozilla-build\\msys\\mingw\\bin;C:\\mozilla-build\\msys\\bin;c:\\windows\\system32;c:\\windows;c:\\windows\\System32\\Wbem;c:\\windows\\System32\\WindowsPowerShell\\v1.0\\;c:\\Program Files (x86)\\Microsoft SQL Server\\100\\Tools\\Binn\\;c:\\Program Files\\Microsoft SQL Server\\100\\Tools\\Binn\\;c:\\Program Files\\Microsoft SQL Server\\100\\DTS\\Binn\\;c:\\Program Files (x86)\\Windows Kits\\8.0\\Windows Performance Toolkit\\;c:\\Program Files (x86)\\Windows Kits\\8.1\\Windows Performance Toolkit\\;c:\\Program Files\\Microsoft SQL Server\\110\\Tools\\Binn\\;c:\\Program Files (x86)\\Microsoft SDKs\\TypeScript\\1.0\\;c:\\Program Files (x86)\\Puppet Labs\\Puppet\\bin;.;C:\\mozilla-build\\msys\\local\\bin;c:\\mozilla-build\\moztools-x64\\bin;c:\\mozilla-build\\vim\\vim72',
06:37:10     INFO -  'PATHEXT': '.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC',
06:37:10     INFO -  'PDBSTR_PATH': '/c/Program Files (x86)/Windows Kits/8.0/Debuggers/x64/srcsrv/pdbstr.exe',
06:37:10     INFO -  'POST_SYMBOL_UPLOAD_CMD': '/usr/local/bin/post-symbol-upload.py',
06:37:10     INFO -  'PROCESSOR_ARCHITECTURE': 'x86',
06:37:10     INFO -  'PROCESSOR_ARCHITEW6432': 'AMD64',
06:37:10     INFO -  'PROCESSOR_IDENTIFIER': 'Intel64 Family 6 Model 30 Stepping 5, GenuineIntel',
06:37:10     INFO -  'PROCESSOR_LEVEL': '6',
06:37:10     INFO -  'PROCESSOR_REVISION': '1e05',
06:37:10     INFO -  'PROGRAMDATA': 'C:\\ProgramData',
06:37:10     INFO -  'PROGRAMFILES': 'C:\\Program Files (x86)',
06:37:10     INFO -  'PROGRAMFILES(X86)': 'C:\\Program Files (x86)',
06:37:10     INFO -  'PROGRAMW6432': 'C:\\Program Files',
06:37:10     INFO -  'PROMPT': '$P$G',
06:37:10     INFO -  'PROPERTIES_FILE': '/c/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/buildprops.json',
06:37:10     INFO -  'PS1': '\\[\\033]0;$MSYSTEM:\\w\\007\n\\033[32m\\]\\u@\\h \\[\\033[33m\\w\\033[0m\\]\n$ ',
06:37:10     INFO -  'PSMODULEPATH': 'C:\\windows\\system32\\WindowsPowerShell\\v1.0\\Modules\\',
06:37:10     INFO -  'PUBLIC': 'C:\\Users\\Public',
06:37:10     INFO -  'PWD': 'c:/Users/cltbld',
06:37:10     INFO -  'RUNNER_CONFIG_CMD': 'c:\\mozilla-build\\buildbotve\\Scripts\\python.exe C:\\mozilla-build\\buildbotve\\Scripts\\runner-script.py -c c:\\opt\\runner\\runner.cfg',
06:37:10     INFO -  'SHELL': 'C:/mozilla-build/msys/bin/sh',
06:37:10     INFO -  'SHLVL': '1',
06:37:10     INFO -  'SSH_AGENT_PID': '336',
06:37:10     INFO -  'SSH_AUTH_SOCK': 'C:/Users/cltbld/AppData/Local/Temp/ssh-IUkAwds736/agent.736',
06:37:10     INFO -  'SYMBOL_SERVER_HOST': 'symbolpush.mozilla.org',
06:37:10     INFO -  'SYMBOL_SERVER_PATH': '/mnt/netapp/breakpad/symbols_ffx/',
06:37:10     INFO -  'SYMBOL_SERVER_SSH_KEY': '/c/Users/cltbld/.ssh/ffxbld_rsa',
06:37:10     INFO -  'SYMBOL_SERVER_USER': 'ffxbld',
06:37:10     INFO -  'SYSTEMDRIVE': 'C:',
06:37:10     INFO -  'SYSTEMROOT': 'C:\\windows',
06:37:10     INFO -  'TEMP': 'C:/Users/cltbld/AppData/Local/Temp',
06:37:10     INFO -  'TERM': 'cygwin',
06:37:10     INFO -  'TEST1': 'testie',
06:37:10     INFO -  'TINDERBOX_OUTPUT': '1',
06:37:10     INFO -  'TMP': 'C:/Users/cltbld/AppData/Local/Temp',
06:37:10     INFO -  'USERDOMAIN': 'B-2008-IX-0110',
06:37:10     INFO -  'USERNAME': 'cltbld',
06:37:10     INFO -  'USERPROFILE': 'C:\\Users\\cltbld',
06:37:10     INFO -  'VS100COMNTOOLS': 'c:\\Program Files (x86)\\Microsoft Visual Studio 10.0\\Common7\\Tools\\',
06:37:10     INFO -  'VS110COMNTOOLS': 'C:\\Program Files (x86)\\Microsoft Visual Studio 11.0\\Common7\\Tools\\',
06:37:10     INFO -  'VS120COMNTOOLS': 'C:\\Program Files (x86)\\Microsoft Visual Studio 12.0\\Common7\\Tools\\',
06:37:10     INFO -  'WINDIR': 'C:\\windows',
06:37:10     INFO -  'WINDOWS_TRACING_FLAGS': '3',
06:37:10     INFO -  'WINDOWS_TRACING_LOGFILE': 'C:\\BVTBin\\Tests\\installpackage\\csilogfile.log',
06:37:10     INFO -  'WIX_351728_PATH': 'c:/mozilla-build/wix-351728',
06:37:10     INFO -  'ZIP_IN': 'c:\\builds\\moz2_slave\\rel-date_firefox_w32_l10n_rpk-\\build\\date\\obj-l10n\\dist\\firefox-42.0.en-US.win32.installer.exe',
06:37:10     INFO -  '_': 'C:\\mozilla-build\\buildbotve\\Scripts\\python'}
06:37:10     INFO -  c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/obj-l10n/_virtualenv/Scripts/python.exe c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/config/nsinstall.py -D ../../dist/branding
06:37:10     INFO -  find c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/obj-l10n/dist/l10n-stage/firefox -maxdepth 1 -print0 | xargs -0 rm -f -r
06:37:10     INFO -  find: c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/obj-l10n/dist/l10n-stage/firefox: No such file or directory
06:37:10     INFO -  c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/obj-l10n/_virtualenv/Scripts/python.exe c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/config/nsinstall.py -D ../../dist/l10n-stage
06:37:10     INFO -  cd ../../dist/l10n-stage && \
06:37:10     INFO -    unzip c:\builds\moz2_slave\rel-date_firefox_w32_l10n_rpk-\build\date\obj-l10n\dist\firefox-42.0.en-US.win32.installer.exe
06:37:10     INFO -  unzip:  cannot find either c:buildsmoz2_slaverel-date_firefox_w32_l10n_rpk-builddateobj-l10ndistfirefox-42.0.en-US.win32.installer.exe or c:buildsmoz2_slaverel-date_firefox_w32_l10n_rpk-builddateobj-l10ndistfirefox-42.0.en-US.win32.installer.exe.zip.
06:37:10     INFO -  c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/toolkit/locales/l10n.mk:88: recipe for target 'c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/obj-l10n/dist/l10n-stage/firefox' failed
06:37:10     INFO -  mozmake.exe: *** [c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/obj-l10n/dist/l10n-stage/firefox] Error 9
06:37:10    ERROR - Return code: 2
06:37:10    ERROR - 2 not in success codes: [0]
06:37:10  WARNING - setting return code to 2
06:37:10    FATAL - Halting on failure while running ['c:/builds/moz2_slave/rel-date_firefox_w32_l10n_rpk-/build/date/mozmake.exe', 'unpack']
06:37:10    FATAL - Running post_fatal callback...
06:37:10    FATAL - Exiting 2
program finished with exit code 2
elapsedTime=2074.283000
The nighlty l10n repacks uses zip files?

06:53:04     INFO -  c:/builds/moz2_slave/m-aurora-w64-l10n-ntly-1-00000/build/mozilla-aurora/obj-l10n/_virtualenv/Scripts/python.exe c:/builds/moz2_slave/m-aurora-w64-l10n-ntly-1-00000/build/mozilla-aurora/config/nsinstall.py -D ../../dist/l10n-stage
06:53:04     INFO -  cd ../../dist/l10n-stage && \
06:53:04     INFO -    unzip c:/builds/moz2_slave/m-aurora-w64-l10n-ntly-1-00000/build/mozilla-aurora/obj-l10n/dist/firefox-43.0a2.en-US.win64.zip
06:53:05     INFO -  Archive:  c:/builds/moz2_slave/m-aurora-w64-l10n-ntly-1-00000/build/mozilla-aurora/obj-l10n/dist/firefox-43.0a2.en-US.win64.zip
06:53:05     INFO -    inflating: firefox/AccessibleMarshal.dll
06:53:05     INFO -    inflating: firefox/application.ini
06:53:05     INFO -    inflating: firefox/browser/blocklist.xml
Attached patch l10n.diffSplinter Review
WIP...
Attached patch tools.diffSplinter Review
This simplifies release-runner.py and instead of using a full URL, we switch to using EN_US_BINARY_URL, compatible with its "brother" :) in the build system, which is actually a prefix, not a full URL.

See example usage of it in the build system: https://dxr.mozilla.org/mozilla-central/source/toolkit/locales/l10n.mk#193

This way we also get rid of prediction the file names, which can be different per-branch (if we change naming schema and decide to ride trains).
Attachment #8673453 - Flags: review?(jlund)
Comment on attachment 8673359 [details] [diff] [review]
l10n.diff

This patch:

* properly relaxes en_us_binary_url config vs runtime requirements
* instead of directly manipulating bootstrap_env['EN_US_BINARY_URL'] it uses replace_dict to interpolate its value from configs
* fixes self.buildbot_config["en_us_binary_url"] usage, which should be self.buildbot_config["properties"].get("en_us_binary_url") actually.

This patch works fine on date with the work around for wget/SSL from bug 1213166, but it's not necessary for nightlies, because we don't use queue.t.n there.

And it generates files! Even on Windows :)
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015/10/2015-10-13-14-55-30-date-l10n/

Logs are available at https://treeherder.mozilla.org/#/jobs?repo=date&revision=7c84e1f08f21 (the question mark jobs).
Attachment #8673359 - Flags: review?(jlund)
Comment on attachment 8673359 [details] [diff] [review]
l10n.diff

Review of attachment 8673359 [details] [diff] [review]:
-----------------------------------------------------------------

neato. so much cleaner!

expecting 'locales' and 'en_us_binary_url' to be in one level deeper in buildbot_config (buildbot_config['properties']) looks like it's part of shared code. will non release jobs be able to find those still?
Attachment #8673359 - Flags: review?(jlund) → review+
Attachment #8673453 - Flags: review?(jlund) → review+
(In reply to Jordan Lund (:jlund) from comment #7)
> Comment on attachment 8673359 [details] [diff] [review]
> l10n.diff
> 
> Review of attachment 8673359 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> neato. so much cleaner!

\o/
 
> expecting 'locales' and 'en_us_binary_url' to be in one level deeper in
> buildbot_config (buildbot_config['properties']) looks like it's part of
> shared code. will non release jobs be able to find those still?

Nightly jobs calculate locales using all-locales from the tree (no such property set in them) and en_us_binary_url from their mozharness configs.
Keywords: leave-open
One more clean up to get rid of release_config_file dependency.
Attachment #8674230 - Flags: review?(jlund)
Blocks: 1213182
Attachment #8674230 - Flags: review?(jlund) → review+
Still broken, but new error:


Uncaught exception: Traceback (most recent call last):
File "/builds/slave/m-cen-lx-l10n-ntly-5-000000000/scripts/mozharness/base/script.py", line 1718, in run
self.run_action(action)
File "/builds/slave/m-cen-lx-l10n-ntly-5-000000000/scripts/mozharness/base/script.py", line 1660, in run_action
self._possibly_run_method(method_name, error_if_missing=True)
File "/builds/slave/m-cen-lx-l10n-ntly-5-000000000/scripts/mozharness/base/script.py", line 1601, in _possibly_run_method
return getattr(self, method_name)()
File "scripts/scripts/desktop_l10n.py", line 765, in repack
self._map(self.repack_locale, self.query_locales())
File "scripts/scripts/desktop_l10n.py", line 485, in _map
result = func(item)
File "scripts/scripts/desktop_l10n.py", line 750, in repack_locale
if self.make_installers(locale) != SUCCESS:
File "scripts/scripts/desktop_l10n.py", line 739, in make_installers
env=env, halt_on_failure=False)
File "scripts/scripts/desktop_l10n.py", line 654, in _make
output_parser=output_parser)
File "/builds/slave/m-cen-lx-l10n-ntly-5-000000000/scripts/mozharness/mozilla/mock.py", line 239, in run_command_m
return self.run_mock_command(mock_target, *args, **kwargs)
File "/builds/slave/m-cen-lx-l10n-ntly-5-000000000/scripts/mozharness/mozilla/mock.py", line 129, in run_mock_command
mock_target, command, cwd, env, **kwargs)
File "/builds/slave/m-cen-lx-l10n-ntly-5-000000000/scripts/mozharness/mozilla/mock.py", line 117, in _do_mock_command
value = value.replace(";", "\\;")
AttributeError: 'NoneType' object has no attribute 'replace'
Running post_fatal callback...
D'oh. Sorry about that.

This time this is different thing: https://bugzilla.mozilla.org/show_bug.cgi?id=1184089#c10
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1213718
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.