1212908 - Update a=simulcast to 03 draft

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P1)

Description

[Byron Campen [:bwc]]

Covers parse, serialization, and test code.

Comment 1

[Byron Campen [:bwc]]

Attachment: MozReview Request: Bug 1212908: Update a=simulcast to match new grammar in 03 draft. r=mt

Bug 1212908: Update a=simulcast to match new grammar in 03 draft.

Comment 2

[Martin Thomson [:mt:]]

Comment on attachment 8676324 [details]
MozReview Request: Bug 1212908: Update a=simulcast to match new grammar in 03 draft. r=mt

https://reviewboard.mozilla.org/r/22661/#review20151

I assume that you are going to update this when you get an answer to your questions on the list regarding mixes of pt and rid on the same a=simulcast line.

::: media/webrtc/signaling/src/sdp/SdpAttribute.cpp:1205
(Diff revision 1)
> +      if (!version.GetChoicesAsFormats(&formats)) {

This is the only place I see this used.  It seems fairly wasteful to have this temporary created here for just validation purposes.

Is it better to store these as strings and strtoul each time they are used, or store them in some sort of variant container?

Comment 3

[Byron Campen [:bwc]]

https://reviewboard.mozilla.org/r/22661/#review20151

Depends on what the answer is. I really hope they at least get rid of sendrecv, but we'll have to see.

> This is the only place I see this used.  It seems fairly wasteful to have this temporary created here for just validation purposes.
> 
> Is it better to store these as strings and strtoul each time they are used, or store them in some sort of variant container?

I anticipate needing this for the simulcast negotiation work also (probably; the dust has still not settled on that spec).

Comment 4

[Byron Campen [:bwc]]

Check back on try retriggers.

Comment 5

[Byron Campen [:bwc]]

Comment on attachment 8676324 [details]
MozReview Request: Bug 1212908: Update a=simulcast to match new grammar in 03 draft. r=mt

Bug 1212908: Update a=simulcast to match new grammar in 03 draft. r=mt

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32fb2eab97cd

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/32fb2eab97cd