Closed Bug 1212908 Opened 5 years ago Closed 5 years ago

Update a=simulcast to 03 draft

Categories

(Core :: WebRTC: Signaling, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed
Blocking Flags:

People

(Reporter: bwc, Assigned: bwc)

References

Details

Attachments

(1 file)

Covers parse, serialization, and test code.
Assignee: nobody → docfaraday
Blocks: 1192390
backlog: --- → webrtc/webaudio+
Rank: 10
Priority: -- → P1
Summary: Update a=simulcast to 02 draft → Update a=simulcast to 03 draft
Bug 1212908: Update a=simulcast to match new grammar in 03 draft.
Attachment #8676324 - Flags: review?(martin.thomson)
Attachment #8676324 - Flags: review?(martin.thomson) → review+
Comment on attachment 8676324 [details]
MozReview Request: Bug 1212908: Update a=simulcast to match new grammar in 03 draft. r=mt

https://reviewboard.mozilla.org/r/22661/#review20151

I assume that you are going to update this when you get an answer to your questions on the list regarding mixes of pt and rid on the same a=simulcast line.

::: media/webrtc/signaling/src/sdp/SdpAttribute.cpp:1205
(Diff revision 1)
> +      if (!version.GetChoicesAsFormats(&formats)) {

This is the only place I see this used.  It seems fairly wasteful to have this temporary created here for just validation purposes.

Is it better to store these as strings and strtoul each time they are used, or store them in some sort of variant container?
https://reviewboard.mozilla.org/r/22661/#review20151

Depends on what the answer is. I really hope they at least get rid of sendrecv, but we'll have to see.

> This is the only place I see this used.  It seems fairly wasteful to have this temporary created here for just validation purposes.
> 
> Is it better to store these as strings and strtoul each time they are used, or store them in some sort of variant container?

I anticipate needing this for the simulcast negotiation work also (probably; the dust has still not settled on that spec).
Check back on try retriggers.
Flags: needinfo?(docfaraday)
Comment on attachment 8676324 [details]
MozReview Request: Bug 1212908: Update a=simulcast to match new grammar in 03 draft. r=mt

Bug 1212908: Update a=simulcast to match new grammar in 03 draft. r=mt
Attachment #8676324 - Attachment description: MozReview Request: Bug 1212908: Update a=simulcast to match new grammar in 03 draft. → MozReview Request: Bug 1212908: Update a=simulcast to match new grammar in 03 draft. r=mt
Flags: needinfo?(docfaraday)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/32fb2eab97cd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.