1212963 - [FTE] FTE Videos for RTL

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Eric Pang [:epang] UX]

FTE Videos need to be revised for RTL localizations

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:ftu-rtl-videos-bug-1212963 > mozilla-b2g:master

Comment 2

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8679714 [details] [review]
[gaia] sfoster:ftu-rtl-videos-bug-1212963 > mozilla-b2g:master

Franciso, I'm not sure if you are familiar with the tutorial code. This change is to let us display language-direction-appropriate video content in the FTU tutorial. I didn't want to further complicate the config/init stuff, so essentially I just make a HEAD request for name-{direction}.ext, and use that if I get a 200ish response, otherwise fallback to using the path as-is from the config. To test it, you can step through as normal and watch logcat/webIDE console to see it try a -ltr.mp4 before loading the non-specific .mp4. If you change to an RTL language (or just set document.dir to 'rtl') you'll see it find the (placeholder) -rtl videos. We'll be updating all the video assets in bug 1212961.

Along the way I refactored out some of the previously private helpers - which were untestable - into a TutorialUtils. With the tutorial unit tests currently disabled (bug 1181201) this gives us a path forward for getting this code back under test. I moved more than I added tests for - let me know if you think I should scale back the refactor. Or write the tests. (time permitting)

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8679714 [details] [review]
[gaia] sfoster:ftu-rtl-videos-bug-1212963 > mozilla-b2g:master

Pretty clear pr, tested on the phone and looking good.

Just left a tiny comment on the pr, not to be implemented now.

Btw, much clearer now the separation with the TutorialUtils class.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Merged to master: https://github.com/mozilla-b2g/gaia/commit/cc8f81cf6102db84d7c4d911c43b0164b4e62ccb

This patch includes placeholder RTL assets (they are just copies of the current (ltr) videos). We'll get the real thing as one drop in bug 1212961, so I'm calling this one done. 

[Blocking Requested - why for this release]: Needed to complete first-class RTL experience in 2.5, without this patch having selected a RTL language users will be presented with a tutorial that doesnt match their actual experience.

Comment 5

[Pi Wei Cheng [:piwei] (inactive)]

This issue is verified fixed on Flame 2.5 and Aries 2.6. First time experience tutorial appears properly while in Arabic.

Device: Aries 2.6
BuildID: 20151123143009
Gaia: bae13c9ac6a91beecd7c94384e2aef25ed1a3214
Gecko: d3d286102ba7f8801e9dfe12d534f49554ba50c0
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Device: Flame 2.5
BuildID: 20151123163948
Gaia: 5839f17dedc757947c9531dc0d66c3c49119f5ea
Gecko: 3a45ca93dd447e046baa2c7590f60ae008e438f8
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0