1213199 - [Messages] 'Message saved as draft' notification is displayed even if draft has been removed afterwards before going to Inbox

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Jessica]

Attachment: logcat_1144.txt

[1.Description]:
[Flame KK v2.5][Aries KK v2.5][Message] Launch message app and send a MMS. After the MMS was sent successfully, long tap it to delete. Then wong suggestions "Message saved as draft" pop up.
Time: 11:44
See attachments: Aries_KK v2.5.png and logcat_1144.txt

[2.Testing Steps]: 
Precondition: There is a SIM card in the DUT.
1.Launch message app and enter new message composer.
2.Add an attachment.
3.Tap sending button.
4.After sending it successfully, long tap the MMS.
5.Select "Delete" from message options.
6.Tap "Delete".

[3.Expected Result]: 
6."Message is deleted" pops up, or no any prompt.

[4.Actual Result]: 
6."Message saved as draft" pops up.

[5.Reproduction build]: 
Device: Aries KK v2.5 (Affected)
Build ID               20151008233852
Gaia Revision          e698df503ff700eb5782e3d50c6eb753567d3451
Gaia Date              2015-10-08 17:26:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/23b7f289df923c01e692299fcd4be7029de8b155
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151008.225742
Firmware Date          Thu Oct  8 22:57:51 UTC 2015
Bootloader             s1

Device: Flame KK v2.5 (Affected)
Build ID               20151008150210
Gaia Revision          e698df503ff700eb5782e3d50c6eb753567d3451
Gaia Date              2015-10-08 17:26:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e5f1bc63ad52d0eb86f7fb838226ca6036774660
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151008.182756
Firmware Date          Thu Oct  8 18:28:08 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.2 (Unaffected)
Build ID               20151008032505
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ab6c34bfacf7
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151008.064723
Firmware Date          Thu Oct  8 06:47:34 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free test

Comment 1

[Jessica]

Attachment: Aries_KK v2.5.png

Comment 2

[Oleg Zasypkin [:azasypkin]]

I'm pretty sure it's regressed by bug 1176976, likely we need to reset "showDraftSavedNotice" if draft has been deleted (once message is sent) after it was saved (once user adds attachment).

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1213199-saved-draft-notification > mozilla-b2g:master

Comment 4

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8672620 [details] [review]
[gaia] azasypkin:bug-1213199-saved-draft-notification > mozilla-b2g:master

Hey Julien,

How does this solution look for you (no test changes yet)?

Thanks!

Comment 5

[Julien Wajsberg [:julienw]]

Just want to mention that deleting the message is not necessary.

Here is the minimal STR for this bug:
1. Enter a conversation.
2. Start writing a message (can be SMS).
3. Press "Home". Under the hood this will save a draft. There are other ways to trigger this though.
4. Enter the Messages app by tapping the Homescreen icon.
5. Send the message.
6. Press back. (note: you don't need to wait that the message is sent).

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 8672620 [details] [review]
[gaia] azasypkin:bug-1213199-saved-draft-notification > mozilla-b2g:master

yep, looks good !

Comment 7

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8672620 [details] [review]
[gaia] azasypkin:bug-1213199-saved-draft-notification > mozilla-b2g:master

Thanks for the feedback, I think it should be ready for review! However I left one question regarding very edgy case at GitHub.

Comment 8

[Julien Wajsberg [:julienw]]

Comment on attachment 8672620 [details] [review]
[gaia] azasypkin:bug-1213199-saved-draft-notification > mozilla-b2g:master

I don't mind the edge case but I don't like the unit test, I think we're testing things that are too internal...

Comment 9

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8672620 [details] [review]
[gaia] azasypkin:bug-1213199-saved-draft-notification > mozilla-b2g:master

Hey Julien,

Does it look better now? :)

Thanks!

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 8672620 [details] [review]
[gaia] azasypkin:bug-1213199-saved-draft-notification > mozilla-b2g:master

r=me

thanks for the new tests !

Comment 11

[Oleg Zasypkin [:azasypkin]]

Master: https://github.com/mozilla-b2g/gaia/commit/c93bdb29e47e2cba9e81aceaf04f084d31e37a64

Comment 12

[Jessica]

Attachment: verified_Aries KK v2.5.3gp

According to the STR of Comment 0, this bug has been verified as pass on latest Flame KK v2.5 and Aries KK v2.5.

Actual results: No any prompt
See attachment: verified_Aries KK v2.5.3gp
Reproduce rate: 0/6


Device: Flame KK v2.5 (Pass)
Build ID               20151019150205
Gaia Revision          a87f947366c2e044bd6336e1982419ac45378969
Gaia Date              2015-10-19 15:22:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151019.182947
Firmware Date          Mon Oct 19 18:29:58 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0


Device: Aries KK v2.5 (Pass)
Build ID               20151019205841
Gaia Revision          a87f947366c2e044bd6336e1982419ac45378969
Gaia Date              2015-10-19 15:22:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9605da94e75d61598d3c00f01a12d1b6bc427a6c
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151019.201730
Firmware Date          Mon Oct 19 20:17:38 UTC 2015
Bootloader             s1