Closed Bug 1213316 Opened 9 years ago Closed 5 years ago

Refactor contact page js

Categories

(www.mozilla.org :: Pages & Content, defect)

Product:
www.mozilla.org
Component:
Pages & Content
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: espressive, Unassigned)

References

Details

(Whiteboard: [kb=1851961]) 

Whilst working on adding a new tab to the contact page, and discussions with :agibson, we agreed that the JS for the contact page is in need of a refactor.

We also need to add unit and functional tests. This bug is to execute that work.
Assignee: nobody → schalk.neethling.bugs
No longer blocks: 1210426
No longer depends on: 1205858
Some things to investigate:

- The current page uses history.js [1], which I believe is no longer maintained. Could look to remove the dependency? Tt is also the cause of some odd logic to handle browser history correctly.
- For older browsers that don't support pushState, I think it's now safe just to serve them the simplified version that IE7 currently gets. This means no hashchange support which should simplify things.

[1] https://github.com/browserstate/history.js
Blocks: 1221087
Assignee: schalk.neethling.bugs → nobody

This was done some time ago

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.