Closed
Bug 1213316
Opened 10 years ago
Closed 6 years ago
Refactor contact page js
Categories
(www.mozilla.org :: Pages & Content, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: espressive, Unassigned)
References
Details
(Whiteboard: [kb=1851961])
Whilst working on adding a new tab to the contact page, and discussions with :agibson, we agreed that the JS for the contact page is in need of a refactor.
We also need to add unit and functional tests. This bug is to execute that work.
| Reporter | ||
Updated•10 years ago
|
Comment 1•10 years ago
|
||
Some things to investigate:
- The current page uses history.js [1], which I believe is no longer maintained. Could look to remove the dependency? Tt is also the cause of some odd logic to handle browser history correctly.
- For older browsers that don't support pushState, I think it's now safe just to serve them the simplified version that IE7 currently gets. This means no hashchange support which should simplify things.
[1] https://github.com/browserstate/history.js
| Reporter | ||
Updated•8 years ago
|
Assignee: schalk.neethling.bugs → nobody
Comment 2•6 years ago
|
||
This was done some time ago
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•