Move release promotion buildbot builders to separate module

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rail, Assigned: jlund)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

It would be great to group all release promotion related builders in a single file module, that can be used from misc.py. http://hg.mozilla.org/build/buildbotcustom/file/ec6cd658f788/misc.py#l3327 is the current entry point.
Assignee: nobody → jlund
I think this is a good idea. Originally it went into misc.py because it gave easy access to ci-style objects, since that's what promotion is closer too. I have a vague memory of some sort of circular import problem which that avoided too.
though not a necessary bug, I took this first as a way to familiarize myself with the buildbot code for build promotion.

this patch:

1) renames generateReleasePromotionObjects to generateReleasePromotionBuilders since we are only creating builder objects and letting bbb schedule/trigger release promotion jobs
2) moves generateReleasePromotionBuilders from misc.py to process/release.py
2) method impl now only returns a list of builders and not a dict of objects and also returns immediately if not a 'release promotion branch' (will make more sense with upcoming buildbot-configs patch
Attachment #8675342 - Flags: review?(rail)
this patch:

1) rather than calling generateReleasePromotionBuilders from within generateReleaseBranchObjects(), we give release promotion builders their own entry call within master.cfg.
2) since generateReleasePromotionBuilders only tracks new builders, this should only be needed for the production build master.cfg (mozilla/builder_master.cfg) and the staging universal master

a dump master diff yielded a no-op for me locally. hopefully production agrees with that :)
Attachment #8675343 - Flags: review?(rail)
same as before but removes old unused var (releasePromotionBuilders) from earlier WIP

interdiff fwiw: http://people.mozilla.org/~jlund/151017_1213317_bbot-cfgs-interdiff.patch
Attachment #8675343 - Attachment is obsolete: true
Attachment #8675343 - Flags: review?(rail)
Attachment #8675345 - Flags: review?(rail)
Attachment #8675342 - Flags: review?(rail) → review+
Attachment #8675345 - Flags: review?(rail) → review+
Hmm, for some reason it doesn't pass check-masters.sh in my environment.
"my environment" was key here, disregard.
Comment on attachment 8675342 [details] [diff] [review]
151017_1213317_give_promotion_logic_its_own_method_entry-buildbotcustom.patch

thanks https://hg.mozilla.org/build/buildbotcustom/rev/c91ff584f674
Attachment #8675342 - Flags: checked-in+
Comment on attachment 8675345 [details] [diff] [review]
151017_1213317_give_promotion_logic_its_own_method_entry-buildbot-configs2.patch

https://hg.mozilla.org/build/buildbot-configs/rev/3fd8f683b28d
Attachment #8675345 - Flags: checked-in+
I think we can close this bug
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.