1213335 - MINIDUMP_STACKWALK not set in buildbot jobs

Status: RESOLVED FIXED

(Testing Graveyard :: external-media-tests, defect)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

We see log output like:
> INFO -   0:22.09 TEST_START: MainThread test_video_playback.py TestVideoPlayback.test_video_playback_partial
> ERROR -   0:24.07 CRASH: MainThread pid:1967. Test:runner.py. Minidump anaylsed:False. Signature:[None]
> INFO -  Crash dump filename: /var/folders/sd/xq4mgmnd085bnsl_k5_qzxk400000w/T/tmp_j4jfS.mozrunner/minidumps/05A2A6CE-A961-4E46-B9A2-7B468820375A.dmp
> INFO -  MINIDUMP_STACKWALK not set, can't process dump.
> INFO -   0:24.09 LOG: MainThread WARNING Failed to gather test failure debug.

Can we set the MINIDUMP_STACKWALK appropriately per platform by changing something in the firefox-media-tests mozharness script or configs? Or does the change need to be made elsewhere on the Releng side?

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

jgriffin, please see my question in the bug description

Comment 2

[Jonathan Griffin (:jgriffin)]

it needs to be set in the mozharness config ala 

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/talos/linux_config.py#8

and

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/talos/linux_config.py#43

and then passed as an env variable when running the tests ala

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/testing/firefox_ui_tests.py#232

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

I used a slightly different approach. Seems to work. Preliminary try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d664a177d33

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c08ef15f971c

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: MozReview Request: Bug 1213335 - set MINIDUMP_STACKWALK for firefox-media-tests; r?jgriffin

Bug 1213335 - set MINIDUMP_STACKWALK for firefox-media-tests; r?jgriffin

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8674296 [details]
MozReview Request: Bug 1213335 - set MINIDUMP_STACKWALK for firefox-media-tests; r?jgriffin

https://reviewboard.mozilla.org/r/22211/#review19807

lgtm!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/92374f60a1c7

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/92374f60a1c7