Closed Bug 1213348 Opened 8 years ago Closed 8 years ago

Turn on system add-on update checks

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(1 file)

patch
1.22 KB, patch
nthomas
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
Start pinging AUS5 for system add-on updates. This generates URLs like:

https://aus5.mozilla.org/update/3/SystemAddons/44.0a1/20151009030230/Darwin_x86_64-gcc3-u-i386-x86_64/en-US/nightly/Darwin%2015.0.0/default/default/update.xml

Which returns an empty updates XML until we set up any rules which is what we want, it means Firefox will just retain whatever system add-ons shipped with the binary.
Attachment #8671991 - Flags: review?(nthomas)
Comment on attachment 8671991 [details] [diff] [review]
patch

r+, although not a peer for Firefox. Third-party folks should disable app update to avoid system addon updates completely, or modify this pref in their builds ?
Attachment #8671991 - Flags: review?(nthomas) → review+
(In reply to Nick Thomas [:nthomas] from comment #1)
> Comment on attachment 8671991 [details] [diff] [review]
> patch
> 
> r+, although not a peer for Firefox. Third-party folks should disable app
> update to avoid system addon updates completely, or modify this pref in
> their builds ?

Yes, clearing this pref or turning off app updates will turn it off.
https://hg.mozilla.org/mozilla-central/rev/b803a0b1008e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox44: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.