1213480 - b2gdroid builds broken after bug 1201206

Status: RESOLVED FIXED

(B2GDroid Graveyard :: General, defect)

Description

[[:fabrice] Fabrice Desré]

Archive:  ../../../../mobile/android/base/geckoview_resources.zip
  inflating: /home/fabrice/dev/builds/obj-b2gdroid/mobile/android/b2gdroid/app/geckoview_resources/values/strings.xml  
    (skipping file '.mkdir.done' due to ANDROID_AAPT_IGNORE pattern '.*')
/home/fabrice/dev/builds/obj-b2gdroid/mobile/android/b2gdroid/app/geckoview_resources/values-v21/styles.xml:12: error: Error retrieving parent for item: No resource found that matches the given name '@style/ThemeOverlay.AppCompat.ActionBar'.

/home/fabrice/dev/builds/obj-b2gdroid/mobile/android/b2gdroid/app/geckoview_resources/values/themes.xml:12: error: Error retrieving parent for item: No resource found that matches the given name 'Theme.AppCompat.Light.DarkActionBar'.

/home/fabrice/dev/builds/obj-b2gdroid/mobile/android/b2gdroid/app/geckoview_resources/values-v11/themes.xml:12: error: Error retrieving parent for item: No resource found that matches the given name 'Theme.AppCompat.Light.DarkActionBar'.

/home/fabrice/dev/builds/obj-b2gdroid/mobile/android/b2gdroid/app/geckoview_resources/values-v21/themes.xml:11: error: Error retrieving parent for item: No resource found that matches the given name 'Theme.AppCompat.Light.DarkActionBar'.

Comment 1

[Nick Alexander :nalexander [he/him]]

The issue is that b2gdroid needs to include the transitive dependencies for GV; in this case, that means adding appcompat-v7.  Crib the lines from mobile/android/base/{moz.build,Makefile.in} for adding appcompat-v7 and add them to m/a/b2gdroid/app/{moz.build,Makefile.in}.  Should be like support-v4.

Sorry for the fallout.

Comment 2

[[:fabrice] Fabrice Desré]

Attachment: geckoview.patch

Also fixing breakage from bug 1173147 that sneaked in around the same time.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8672169 [details] [diff] [review]
geckoview.patch

Review of attachment 8672169 [details] [diff] [review]:
-----------------------------------------------------------------

If it works for you, it works for me!

::: mobile/android/b2gdroid/app/Makefile.in
@@ +30,5 @@
>  ANDROID_EXTRA_JARS += \
>  	$(ANDROID_SUPPORT_ANNOTATIONS_JAR_LIB) \
>  	$(ANDROID_SUPPORT_V4_AAR_LIB) \
>  	$(ANDROID_SUPPORT_V4_AAR_INTERNAL_LIB) \
> +  $(ANDROID_APPCOMPAT_V7_AAR_LIB) \

nit: indentation.  spaces, not tabs.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/370e515aa882

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/370e515aa882