1213512 - getUserMedia({ }) should be a TypeError

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

rather than NotSupportedError.

Comment 1

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 2

[Karl Tomlinson (:karlt)]

On m-c now, this is a MediaStreamError that looks a bit like a TypeError.

https://treeherder.mozilla.org/jobs?repo=try&revision=c924f53b2fae48743f898a77d874c916d5875dfd

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: Bug 1213512 don't end tests before then() handler has run r?pehrsons

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: Bug 1213512 improve checks on TypeError getUserMedia() rejection reason r?jib

Depends on D95961

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: Bug 1213512 improve checks on NotAllowedError getUserMedia() rejection reason r?jib

Depends on D95962

Comment 6

[Karl Tomlinson (:karlt)]

Attachment: Bug 1213512 improve checks on InvalidStateError and TypeError getDisplayMedia() rejections r?jib

Depends on D95963

Comment 7

[Karl Tomlinson (:karlt)]

Attachment: Bug 1213512 add a constraint so that mozGetUserMedia does not fail immediately r?jib

https://bug802982.bmoattachments.org/attachment.cgi?id=672704 was a crash in
EnumerateVideoDevices. Presumably the constraint was not required at that
time, but the intent of the test was to exercise video capture code.

Depends on D95964

Comment 8

[Karl Tomlinson (:karlt)]

Attachment: Bug 1213512 remove unused MediaStreamError constructor r?jib

Depends on D95965

Comment 9

[Karl Tomlinson (:karlt)]

Attachment: Bug 1213512 use UTF8 for MediaMgrError and SpeechRecognitionError message r?jib

for consistency with ErrorResult and dom::Promise, which will mean no reverse
conversion is required for rejecting Promises.

Depends on D95966

Comment 10

[Karl Tomlinson (:karlt)]

Attachment: Bug 1213512 remove unused NS_ERROR_DOM_FILE_ABORT_ERR r?baku

Depends on D95967

Comment 11

[Karl Tomlinson (:karlt)]

Attachment: Bug 1213512 use a DOMException for MaybeRejectWithNotReadableError() r?baku

This is consistent with
https://w3c.github.io/FileAPI/#dfn-error-codes

Depends on D95968

Comment 12

[Karl Tomlinson (:karlt)]

Attachment: Bug 1213512 remove unused MediaMgrErr::Name::NotSupportedError r?jib

Depends on D95969

Comment 13

[Karl Tomlinson (:karlt)]

Attachment: Bug 1213512 reject MediaDevices method promises with existing standard errors r?jib

OverconstrainedError is not yet supported.

Depends on D95970

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5488c1091312
don't end tests before then() handler has run r=pehrsons
https://hg.mozilla.org/integration/autoland/rev/6685a2c5158a
improve checks on TypeError getUserMedia() rejection reason r=jib
https://hg.mozilla.org/integration/autoland/rev/38a5df003dcc
improve checks on NotAllowedError getUserMedia() rejection reason r=jib
https://hg.mozilla.org/integration/autoland/rev/21aa4a24335f
improve checks on InvalidStateError and TypeError getDisplayMedia() rejections r=jib
https://hg.mozilla.org/integration/autoland/rev/f9b1c03019a6
add a constraint so that mozGetUserMedia does not fail immediately r=jib
https://hg.mozilla.org/integration/autoland/rev/e20da67e6306
remove unused MediaStreamError constructor r=jib
https://hg.mozilla.org/integration/autoland/rev/992a979b7285
use UTF8 for MediaMgrError and SpeechRecognitionError message r=jib
https://hg.mozilla.org/integration/autoland/rev/f10b1dba4d05
remove unused NS_ERROR_DOM_FILE_ABORT_ERR r=baku
https://hg.mozilla.org/integration/autoland/rev/fedd5a65269a
use a DOMException for MaybeRejectWithNotReadableError() r=baku
https://hg.mozilla.org/integration/autoland/rev/c8dfeadab096
remove unused MediaMgrErr::Name::NotSupportedError r=jib
https://hg.mozilla.org/integration/autoland/rev/13e7ec11d449
reject MediaDevices method promises with existing standard errors r=jib

Comment 15

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26539 for changes under testing/web-platform/tests

Comment 16

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 17

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/5488c1091312
https://hg.mozilla.org/mozilla-central/rev/6685a2c5158a
https://hg.mozilla.org/mozilla-central/rev/38a5df003dcc
https://hg.mozilla.org/mozilla-central/rev/21aa4a24335f
https://hg.mozilla.org/mozilla-central/rev/f9b1c03019a6
https://hg.mozilla.org/mozilla-central/rev/e20da67e6306
https://hg.mozilla.org/mozilla-central/rev/992a979b7285
https://hg.mozilla.org/mozilla-central/rev/f10b1dba4d05
https://hg.mozilla.org/mozilla-central/rev/fedd5a65269a
https://hg.mozilla.org/mozilla-central/rev/c8dfeadab096
https://hg.mozilla.org/mozilla-central/rev/13e7ec11d449