1213583 - line-height jumps to 1.2 rather than font's 1.0 at certain round sizes of downloadable font with 0 internal and external leading

Status: NEW

(Core :: Graphics: Text, defect, P3)

Description

[NVale]

Attachment: test.zip

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150929144111

Steps to reproduce:

Create font with the following metrics:
Units per EM = 2000
Ascender = 1800
Descender = -200
LineGap = 0
TypoAscender = 1800
TypoDescender = -200
TypoLineGap = 0
WinAscent = 1800
WinDescent = -200
XHeight = 1000
CapHeight = 1400

Font must contain at least one glyph.

Embed font with @font-face and display any existing glyph.



Actual results:

line-height is abnormal (very large) at certain font sizes, for example: 40px, 80px, 100px, 200px.

For example: 
At font size = 201px the line-height is 201px. 
At font size = 200px the line-height is 240px. 




Expected results:

line-height should be normal size at all font-sizes.

Comment 1

[NVale]

Attachment: Image.gif

Screenshot

Comment 2

[Michelle Funches - QA]

@Reporter - are you still experiencing this issue? Have you applied Firefox update 42.0?

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Testing in 42 isn't useful if it's been reported in 41.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Reporter, I'm curious if you see the same result if you go to about:config, change the preference browser.display.normal_lineheight_calc_control, from its initial value of 2, to 1, and restart the browser?  I suspect the behavior will go away, but it would be good to confirm.

I don't see the problem on Linux; I see the 240px line-height in both cases.

This is because, by default, the function GetNormalLineHeight in layout/generic/nsHTMLReflowState.cpp replaces the font-provided leading with 1.2 if there is neither internal nor external leading.  I suspect that on Windows something related to rounding is causing there to be a very small nonzero amount of leading at some font sizes, but not at particularly round ones.

I guess there are two questions:
 (1) whether we do want to retain that defaulting-to-1.2 behavior
 (2) whether we can fix the rounding issue, or whether it needs some tolerance around 0.

Comment 5

[NVale]

(In reply to Michelle Funches - QA from comment #2)
> @Reporter - are you still experiencing this issue? Have you applied Firefox
> update 42.0?

Firefox 42.0 has the same issue.

Comment 6

[NVale]

(In reply to David Baron [:dbaron] ⌚UTC-8 from comment #4)
> Reporter, I'm curious if you see the same result if you go to about:config,
> change the preference browser.display.normal_lineheight_calc_control, from
> its initial value of 2, to 1, and restart the browser?  I suspect the
> behavior will go away, but it would be good to confirm.

I have changed "browser.display.normal_lineheight_calc_control" from 2 to 1, restarted the browser and got normal line-height. I confirm you are right, the behavior go away!

Comment 7

[Michelle Funches - QA]

@Reporter & D. Baron, as we are cleaning up old bugs I will update the Status of this to Resolved - WorksForMe. Please apply any other action necessary to complete closure.  Thanks all.

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

No, that's incorrect.  The bug is still present in our default configuration.

Comment 9

[Michelle Funches - QA]

Acknowledge: I did not read through accurately; Thanks for the clarification & status update.

Comment 10

[Jonathan Kew [:jfkthame]]

This sounds a lot like the Mac OS X issue described in bug 832313, where we have a similar situation where rounding sometimes results a calculated leading of zero, and hence the 1.2 factor kicks in.

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I wonder if we should not use the use-1.2-instead code if the font is downloaded rather than from the system.

Comment 12

[NVale]

Still exists in version 46... :(