1213615 - Contacts action menu cancel button is missing the background

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1213615_contacts_action_menu_cancel_bg > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8672318 [details] [review]
[gaia] KevinGrandon:bug_1213615_contacts_action_menu_cancel_bg > mozilla-b2g:master

Francisco - would you mind giving this a review? We just need to add a wrapping container around the last button in order to match the new format of the building block.

The change to the shared/ code landed here: https://github.com/mozilla-b2g/gaia/commit/d6cc7ef0b409af4b83d0d1ccc7c1f4ddba28284e

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8672318 [details] [review]
[gaia] KevinGrandon:bug_1213615_contacts_action_menu_cancel_bg > mozilla-b2g:master

LGTM, tried on the phone and looking nice.

Thanks Kevin!

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Landed on master:


https://github.com/mozilla-b2g/gaia/commit/0b934d06c04adff2cd9bdd0bc204f974a18b710f

Comment 5

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5&2.6 and Aires KK 2.6 by the STR in comment 0.

Actual results: The Cancel button shows normally on Contacts action menu.
See attachment: verified_Flame_v2.6.png
Reproduce rate: 0/10


Device: Flame KK 2.5 512mb (Pass)
Build ID               20151103004501
Gaia Revision          91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gaia Date              2015-10-28 20:32:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4e0955369a51850f2982087145ac5c2df257ffe9
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151103.054921
Firmware Date          Tue Nov  3 05:49:36 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 512mb (master)(Pass)
Build ID               20151103150203
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151103.182550
Firmware Date          Tue Nov  3 18:26:03 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.6 (master)(Pass)
Build ID               20151104004249
Gaia Revision          61918ddd9ccce104c009e873e34a0791e125753a
Gaia Date              2015-11-03 17:22:30
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f742b9412ed5aace90ad863b276faae0641090a8
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151104.000116
Firmware Date          Wed Nov  4 00:01:24 UTC 2015
Bootloader             s1

Comment 6

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.6.png

Comment 7

[Shally Li（leave from Mozilla）]

> This bug has been verified as "pass" on the latest build of Flame KK 2.5&2.6
> and Aires KK 2.6 by the STR in comment 0.

Update the STR of comment 5, my verified STR is:

1. Open the contact app.
2. Open a contact.
3. Tap 'Share Contact' button.

Comment 8

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest Aires KK 2.5 by the STR in comment 0.

Actual results: The Cancel button shows normally on Contacts action menu as same as mentioned in comment 5.
See above attachment "verified_Flame_v2.6.png".
Reproduce rate: 0/10

Device: Aries KK 2.5 (Pass)
Build ID               20151107112205
Gaia Revision          577948202ae12154524a2bd2bd6d467838ad50b8
Gaia Date              2015-11-07 10:00:59
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae7b8b1fd9e1504347b938820f99d75058049386
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151107.104119
Firmware Date          Sat Nov  7 10:41:27 UTC 2015
Bootloader             s1

Comment 9

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest Aires KK 2.5 by the STR in comment 7.

Actual results: The Cancel button shows normally on Contacts action menu as same as mentioned in comment 5.
See above attachment "verified_Flame_v2.6.png".
Reproduce rate: 0/10

Device: Aries KK 2.5 (Pass)
Build ID               20151107112205
Gaia Revision          577948202ae12154524a2bd2bd6d467838ad50b8
Gaia Date              2015-11-07 10:00:59
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae7b8b1fd9e1504347b938820f99d75058049386
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151107.104119
Firmware Date          Sat Nov  7 10:41:27 UTC 2015
Bootloader             s1