1213620 - DownloadsButton defined as const so extensions can't access it

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Matthew Turnbull [Bluefang]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20151009030230

Steps to reproduce:

Trying to access DownloadsButton or window.DownloadsButton, from within an extensions XUL overlay, is undefined.

This prevents extension from interacting with the download panel anchor. For example, Status4Evar uses DownloadsButton to conditionally swap out the panel's anchor, which is not possible using DownloadsIndicatorView if "downloads-button" isn't on a toolbar.

Other components of the download button/indicator/panel use XPCOMUtils.defineConstant or similar, but DownloadsButton does not.

Comment 1

[:Gijs (he/him)]

Fancy creating a patch?

Comment 2

[Matthew Turnbull [Bluefang]]

Attachment: bug1213620-DownloadsButton-global.patch

I suppose there's a first time for everything. I verified this my modifying my local omni.js instead of compiling, so hopefully that's sufficient.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8672419 [details] [diff] [review]
bug1213620-DownloadsButton-global.patch

Thanks, LGTM!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/dad706141d03

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dad706141d03