Closed
Bug 1213700
Opened 10 years ago
Closed 10 years ago
When creating a livemark, wrong item gets edited
Categories
(SeaMonkey :: Bookmarks & History, defect)
SeaMonkey
Bookmarks & History
Tracking
(seamonkey2.40 fixed, seamonkey2.41 fixed)
RESOLVED
FIXED
seamonkey2.41
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
2.77 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Steps to reproduce problem:
1. View a feed
2. Try to subscribe using Live Bookmarks
Expected result: Dialog allows you to rename the new live bookmark
Actual result: Dialog edits unrelated bookmark
|
Assignee | |
Comment 1•10 years ago
|
||
Creating livemarks is now asynchronous, sigh, so we have to wait for it to complete before filling in the dialog, which is ugly, but there you go.
Attachment #8672417 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Updated•10 years ago
|
Summary: When editing a livemark, wrong item gets edited → When creating a livemark, wrong item gets edited
Comment on attachment 8672417 [details] [diff] [review]
Possible patch
The equivalent Firefox code makes use of yield, is this something we should be doing?
Flags: needinfo?(neil)
Attachment #8672417 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
When you start doing that you have to start messing around with Tasks too and I thought that was overkill.
Flags: needinfo?(neil)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.41
|
|
Assignee | |
Comment 5•10 years ago
|
||
Comment on attachment 8672417 [details] [diff] [review]
Possible patch
[Approval Request Comment]
Regression caused by (bug #): 1094900
String changes made by this patch: None
Attachment #8672417 -
Flags: approval-comm-aurora?
Attachment #8672417 -
Flags: approval-comm-aurora? → approval-comm-aurora+
|
|
Assignee | |
Comment 6•10 years ago
|
||
Pushed comm-beta changeset e39e894b9640.
status-seamonkey2.40:
--- → fixed
status-seamonkey2.41:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•