Closed
Bug 1213897
Opened 9 years ago
Closed 9 years ago
Extract DelayedScheduler out of MDSM to a common class for easier reuse by other classes.
Categories
(Core :: Audio/Video: Playback, defect, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: kikuo, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
5.97 KB,
patch
|
kikuo
:
review+
|
Details | Diff | Splinter Review |
According to the last issue in Bug 1194918 Comment 32, I think it's good to extract DelayedScheduler out of MDSM and make it more general for easier use by other classes.
Reporter | ||
Comment 1•9 years ago
|
||
Bug 1213897 - Extract DelayedScheduler out of MDSM to a common class. r?jwwang
Attachment #8672664 -
Flags: review?(jwwang)
Comment 2•9 years ago
|
||
Comment on attachment 8672664 [details]
MozReview Request: Bug 1213897 - Extract DelayedScheduler out of MDSM to a common class. r?jwwang
https://reviewboard.mozilla.org/r/21761/#review19575
nice!
Attachment #8672664 -
Flags: review?(jwwang) → review+
Reporter | ||
Comment 3•9 years ago
|
||
Reporter | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
Hi Kilik, this failed to apply to mozilla-inbound
applying 6d94aba4bdb6
patching file dom/media/MediaDecoderStateMachine.cpp
Hunk #2 FAILED at 2855
1 out of 2 hunks FAILED -- saving rejects to file dom/media/MediaDecoderStateMachine.cpp.rej
could you take a look, thanks!
Flags: needinfo?(kikuo)
Keywords: checkin-needed
Reporter | ||
Comment 5•9 years ago
|
||
Rebase to trunk and carry r+ from Comment 2.
Should be applied without problem now : )
Thanks Carsten.
Flags: needinfo?(kikuo)
Attachment #8672954 -
Flags: review+
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8672664 [details]
MozReview Request: Bug 1213897 - Extract DelayedScheduler out of MDSM to a common class. r?jwwang
Avoid confusion
Attachment #8672664 -
Attachment is obsolete: true
Reporter | ||
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Updated•9 years ago
|
Priority: -- → P2
Comment 8•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•