1213921 - Tablet: Secondary user accounts are treated as restricted profile

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Reported by "kkus" on IRC.

A secondary account created on a tablet is erroneously treated as "restricted profile". Thus all default restrictions are enforced for this user (e.g. No private browsing, no add-ons, ..).

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

A secondary user has a single active restriction and this breaks our "restricted profile" detection:
> no_sms = true

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

We tweaked this part of the code several times. After further investigation I think the only safe way to detect a restricted profile is to check only the app restriction bundle. This will only contain restrictions if we injected them via the broadcast receiver during profile setup. The user bundle can basically contain whatever and is no clear indicator (On Android M: no_record_audio=false, On a secondary account: no_sms=true).

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: 1213921-restricted-profile.patch

Tested this on Android M/6.0. As well as on a tablet with normal, secondary and restricted user. This seems to work with all variations now.

Comment 4

[Allison Naaktgeboren :ally]

Comment on attachment 8673025 [details] [diff] [review]
1213921-restricted-profile.patch

Review of attachment 8673025 [details] [diff] [review]:
-----------------------------------------------------------------

I would like to hear more about your investigation, but that can wait until we've patched this bug.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/0d6ceca76006

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0d6ceca76006

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8673025 [details] [diff] [review]
1213921-restricted-profile.patch

Approval Request Comment

[Feature/regressing bug #]: Family friendly browsing (Support for "restricted profiles") - Project "KidFox". New feature in Firefox for Android 42.

[User impact if declined]: Secondary users on tablets and phone are treated as "restricted profile". Therefore all default restrictions for family friendly browsing will be enforced (No private browsing, No way to clear history, No add-ons, ..)

[Describe test coverage new/current, TreeHerder]: Local testing on different devices: Normal profile, Guest profile and Restricted profile. There's no UI test support for restricted profiles yet.

[Risks and why]: Low - "Restricted profile" detection has been tested with all known profile types.

[String/UUID change made/needed]: -

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8673025 [details] [diff] [review]
1213921-restricted-profile.patch

Sure, taking it. Should be in 42 beta 8.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/67a206fb7107

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/135164c79784

Comment 11

[u421692]

Verified as fixed on Firefox 42 Beta 8, latest Aurora and Nightly