Closed Bug 1213966 Opened 4 years ago Closed 4 years ago

Icon for new memory tool

Categories

(DevTools :: Memory, defect)

defect
Not set

Tracking

(firefox44 verified)

VERIFIED FIXED
Firefox 44
Tracking Status
firefox44 --- verified

People

(Reporter: ntim, Assigned: hholmes)

References

Details

(Whiteboard: [devtools-ux][bugday-20151125])

Attachments

(2 files)

Possible ways to represent memory:
- A small graph
- A bunch of small boxes that represent how memory is allocated
- A small RAM chip


Other ideas:
- https://thenounproject.com/search/?q=memory
- https://thenounproject.com/search/?q=byte
- https://thenounproject.com/search/?q=chip
Component: Developer Tools: Performance Tools (Profiler/Timeline) → Developer Tools: Memory
:Optimizer had previously made a timeline tool, and its icon is pretty interesting: https://raw.githubusercontent.com/scrapmac/Graphical-Timeline-of-Events/master/skin/images/tool-timeline.png
A brain could be a good icon too, I've seen that in some memory tools.
Helen, is this something doable in time for Nov 3rd?
Flags: needinfo?(hholmes)
I'll make sure it gets done by the end of the week!
Assignee: nobody → hholmes
Status: NEW → ASSIGNED
Flags: needinfo?(hholmes)
Attachment #8680238 - Flags: review?(jsantell)
I should mention my attachment only has the icon, not the icon hooked up to the panel :/
Wires up Helen's icon, and adds an active state version
Attachment #8680264 - Flags: review?(nfitzgerald)
Attachment #8680264 - Flags: review?(nfitzgerald) → review+
Comment on attachment 8680264 [details] [diff] [review]
1213966-memory-icon.patch

Review of attachment 8680264 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/themes/images/tool-memory.svg
@@ +1,5 @@
> +<!-- This Source Code Form is subject to the terms of the Mozilla Public
> +   - License, v. 2.0. If a copy of the MPL was not distributed with this
> +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> +<svg height="16" width="16" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" fill="whitesmoke">
> +    <path opacity="0.2" d="M5.8 3.9l4.9.1v8.3H5.8z"/>

nit: please use 2-space indentation here

::: devtools/client/themes/images/tool-memory-active.svg
@@ +1,5 @@
> +<!-- This Source Code Form is subject to the terms of the Mozilla Public
> +   - License, v. 2.0. If a copy of the MPL was not distributed with this
> +   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
> +<svg height="16" width="16" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" fill="#71c054">
> +    <path opacity="0.2" d="M5.8 3.9l4.9.1v8.3H5.8z"/>

Same.
Attachment #8680238 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/ec9458c922de
https://hg.mozilla.org/mozilla-central/rev/a209e72c3b13
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Reproduced this bug with Nightly 44.0a1 (2015-10-12);(Build ID: 20151012030612) on Linux, 64 Bit

Bug is now verified as fixed on Latest Firefox Developer Edition 44.0a2 (2015-11-25)

Build ID: 20151125004042
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Firefox/44.0
QA Whiteboard: [bugday-20151125]
I have reproduced this bug with Firefox Nightly 44.0a1 (Build ID: 20151012030612) on 
windows 8.1 64-bit .

Verified as fixed with Firefox Aurora 44.0a2 (Build ID: 20151125004042)

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0

As this bug is also verified on Linux(Comment 11) ,I am marking this as verified.
Status: RESOLVED → VERIFIED
Whiteboard: [devtools-ux] → [devtools-ux][bugday-20151125]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.