1213984 - Remove contacts code from Loop's backend

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mark Banner (:standard8)]

Following on from bug 1212079, we should remove the contacts backend

See the user story for more detail.

Comment 1

[Manuel Casas Barrado [:mancas]]

Attachment: Remove contacts code from Loop's backend

Hey Mark, I've removed the useless code. Perhaps, I missed something, so please, check the patch and let me know if there is something wrong

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8683566 [details] [diff] [review]
Remove contacts code from Loop's backend

Review of attachment 8683566 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks good so far. I noticed a couple of minor other removals that we can do as well.

::: browser/components/loop/test/mochitest/browser.ini
@@ +5,3 @@
>      fixtures/google_groups.txt
>      fixtures/google_token.txt
>      google_service.sjs

You should be able to remove these *google* entries as well, and the associated files.

There's also a few test-only prefs to remove that I noticed when I searched for the sjs file:

http://mxr.mozilla.org/mozilla-central/search?string=google_service.sjs

@@ +14,1 @@
>  skip-if = e10s

You need to drop the skip-if line here as well. That was skipping just the browser_GoogleImporter.js test for e10s.

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: Remove contacts code from Loop's backend

Google code has been removed \o/

However, I can't run the tests because of a weird error that I'm getting when running |run-all-loop-tests|. (Commented on IRC)

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8684133 [details] [diff] [review]
Remove contacts code from Loop's backend

Review of attachment 8684133 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I've given the tests a run and they're passing as well.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/adf257bef068

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/adf257bef068

Comment 7

[Ed Lee :Mardak]

Comment on attachment 8684133 [details] [diff] [review]
Remove contacts code from Loop's backend

>+++ b/browser/components/loop/moz.build
> EXTRA_JS_MODULES.loop += [
>     'content/shared/js/crypto.js',
>     'content/shared/js/utils.js',
>-    'modules/CardDavImporter.jsm',
>-    'modules/GoogleImporter.jsm',
>-    'modules/LoopContacts.jsm',
>     'modules/LoopRooms.jsm',
>     'modules/LoopRoomsCache.jsm',
>-    'modules/LoopStorage.jsm',

>diff --git a/browser/components/loop/modules/CardDavImporter.jsm b/browser/components/loop/modules/CardDavImporter.jsm
>deleted file mode 100644
>diff --git a/browser/components/loop/modules/GoogleImporter.jsm b/browser/components/loop/modules/GoogleImporter.jsm
>deleted file mode 100644
>diff --git a/browser/components/loop/modules/LoopContacts.jsm b/browser/components/loop/modules/LoopContacts.jsm
>deleted file mode 100644

Looks like LoopStorage.jsm didn't actually get removed.

https://dxr.mozilla.org/mozilla-central/search?q=path%3ALoopStorage.jsm

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/dab23401215e

Comment 9

[Mark Banner (:standard8)]

(In reply to Pulsebot from comment #8)
> https://hg.mozilla.org/integration/fx-team/rev/dab23401215e

This part removed LoopStorage.jsm.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dab23401215e