Closed Bug 1213984 Opened 4 years ago Closed 4 years ago

Remove contacts code from Loop's backend

Categories

(Hello (Loop) :: Client, defect, P2)

defect

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: standard8, Assigned: mancas)

References

Details

(Whiteboard: [web sharing])

User Story

Acceptance criteria:

- All contacts code removed from backend, e.g. LoopContacts, GoogleImporter, CardDavImporter, LoopStorage.
- Any associated preferences removed (from firefox.js)
- Any relevant tests removed, remaining tests pass

Attachments

(1 file, 1 obsolete file)

Following on from bug 1212079, we should remove the contacts backend

See the user story for more detail.
Rank: 18
Rank: 18 → 20
Rank: 20 → 23
Assignee: nobody → b.mcb
Hey Mark, I've removed the useless code. Perhaps, I missed something, so please, check the patch and let me know if there is something wrong
Attachment #8683566 - Flags: feedback?(standard8)
Comment on attachment 8683566 [details] [diff] [review]
Remove contacts code from Loop's backend

Review of attachment 8683566 [details] [diff] [review]:
-----------------------------------------------------------------

Yep, looks good so far. I noticed a couple of minor other removals that we can do as well.

::: browser/components/loop/test/mochitest/browser.ini
@@ +5,3 @@
>      fixtures/google_groups.txt
>      fixtures/google_token.txt
>      google_service.sjs

You should be able to remove these *google* entries as well, and the associated files.

There's also a few test-only prefs to remove that I noticed when I searched for the sjs file:

http://mxr.mozilla.org/mozilla-central/search?string=google_service.sjs

@@ +14,1 @@
>  skip-if = e10s

You need to drop the skip-if line here as well. That was skipping just the browser_GoogleImporter.js test for e10s.
Attachment #8683566 - Flags: feedback?(standard8) → feedback+
Google code has been removed \o/

However, I can't run the tests because of a weird error that I'm getting when running |run-all-loop-tests|. (Commented on IRC)
Attachment #8683566 - Attachment is obsolete: true
Attachment #8684133 - Flags: review?(standard8)
Comment on attachment 8684133 [details] [diff] [review]
Remove contacts code from Loop's backend

Review of attachment 8684133 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, I've given the tests a run and they're passing as well.
Attachment #8684133 - Flags: review?(standard8) → review+
https://hg.mozilla.org/mozilla-central/rev/adf257bef068
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment on attachment 8684133 [details] [diff] [review]
Remove contacts code from Loop's backend

>+++ b/browser/components/loop/moz.build
> EXTRA_JS_MODULES.loop += [
>     'content/shared/js/crypto.js',
>     'content/shared/js/utils.js',
>-    'modules/CardDavImporter.jsm',
>-    'modules/GoogleImporter.jsm',
>-    'modules/LoopContacts.jsm',
>     'modules/LoopRooms.jsm',
>     'modules/LoopRoomsCache.jsm',
>-    'modules/LoopStorage.jsm',

>diff --git a/browser/components/loop/modules/CardDavImporter.jsm b/browser/components/loop/modules/CardDavImporter.jsm
>deleted file mode 100644
>diff --git a/browser/components/loop/modules/GoogleImporter.jsm b/browser/components/loop/modules/GoogleImporter.jsm
>deleted file mode 100644
>diff --git a/browser/components/loop/modules/LoopContacts.jsm b/browser/components/loop/modules/LoopContacts.jsm
>deleted file mode 100644

Looks like LoopStorage.jsm didn't actually get removed.

https://dxr.mozilla.org/mozilla-central/search?q=path%3ALoopStorage.jsm
(In reply to Pulsebot from comment #8)
> https://hg.mozilla.org/integration/fx-team/rev/dab23401215e

This part removed LoopStorage.jsm.
You need to log in before you can comment on or make changes to this bug.