1214015 - add short_revision and long_revision fields to result_set and revision tables

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Cameron Dawson [:camd]]

These two fields will be used to store:
``short_revision``: 12 char revision SHA
``long_revision``: 40 char revision SHA

These are new to the ``result_set`` table and additions to the ``revision`` field on the ``revisions`` table.

Comment 1

[Cameron Dawson [:camd]]

Attachment: PR

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8672829 [details] [review]
PR

Travis is failing

Comment 3

[Cameron Dawson [:camd]]

Ed- yeah, I just noticed that and fixed it.  I was moving too many parts at once.  :/

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8672829 [details] [review]
PR

Left some comments :-)

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 8672829 [details] [review]
PR

Ping pong, back to you.  Yeah, agree with making them non-unique.  Fixed.

Comment 6

[Ed Morley [:emorley]]

Comment on attachment 8672829 [details] [review]
PR

Looks good :-)

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/36015e28b1b8215b834da274f44bb0288107d82d
Bug 1214015 - add short_revision and long_revision fields to result_set and revision tables

Adds support for storing and searching by either a 12 char or 40 char
revision

On the ``result_set`` table, these fields indicate the short and long
revisions of the top revision for that push.

On the revisions table, eventually, ``short_revision`` will replace the
``revision`` field.

Comment 8

[Cameron Dawson [:camd]]

added fields to stage and production servers.  But I haven't yet for heroku.  

Ed:  is there a documented process for doing that yet?

Comment 9

[Ed Morley [:emorley]]

For the per-repo tables use |heroku run -- manage.py run_sql -s "SQL STATEMENT;"|

For the treeherder table use mysqlworkbench or the command line client, along with the steps in bug 1165259 comment 1 onwards. (The heroku dynos don't have the command line mysql client installed so |heroku run manage.py dbshell| won't work).

Comment 10

[Cameron Dawson [:camd]]

Thanks Ed!  I added all the fields, plus the ``last_modified`` field from another PR that I neglected to update.  Man, this is so much nicer than doing the other servers!  :)