Closed Bug 1214029 Opened 4 years ago Closed 4 years ago

Use double-quotes for strings in alert.js

Categories

(Toolkit :: Notifications and Alerts, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jaws, Assigned: jaws)

Details

Attachments

(1 file)

Many strings within toolkit/components/alerts/resources/content/alert.js use single-quotes for strings, when it is common convention to use double-quotes.
Attached patch PatchSplinter Review
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8673148 - Flags: review?(MattN+bmo)
Comment on attachment 8673148 [details] [diff] [review]
Patch

Review of attachment 8673148 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I also wanted to clean this up.
Attachment #8673148 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/705465b1504b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.