Closed Bug 1214029 Opened 9 years ago Closed 9 years ago

Use double-quotes for strings in alert.js

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect)

Product:
Toolkit Graveyard
Component:
Notifications and Alerts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: jaws, Assigned: jaws)

Details

Attachments

(1 file)

Patch
5.19 KB, patch
MattN
: review+
Details | Diff | Splinter Review 
Many strings within toolkit/components/alerts/resources/content/alert.js use single-quotes for strings, when it is common convention to use double-quotes.
Attached patch Patch — — Splinter Review 
Assignee: nobody → jaws
Status: NEW → ASSIGNED

        Attachment #8673148 -
        Flags: review?(MattN+bmo)

    
    

    
  
Comment on attachment 8673148 [details] [diff] [review]
Patch

Review of attachment 8673148 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I also wanted to clean this up.

        Attachment #8673148 -
        Flags: review?(MattN+bmo) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/705465b1504b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox44:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

    
  
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: