Closed Bug 1214179 Opened 4 years ago Closed 4 years ago

[Presentation WebAPI] regression after changing device Id from service name to host name

Categories

(Core :: DOM: Core & HTML, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: schien, Assigned: schien)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file, 3 obsolete files)

Attached patch self-host-resolution.patch (obsolete) — Splinter Review
After 1194049 landed, TCPPresentationServer uses mDNS host name for indexing available devices. On receiver side we need to found the matched device with the |id| in sessionInit message. Therefore we need to query the self host name on sender side as well.
Comment on attachment 8673064 [details] [diff] [review]
self-host-resolution.patch

I also resolved one device list maintenance bug as well. We need to remove items from |mDevices| if TCPPresentationServer is restarted (e.g. while network status change).
Summary: [Presentation WebAPI] corresponding fix after using host name in multicastDNSDeviceProvider for indexing device list. → [Presentation WebAPI] provide device ID to TCPPresentationServer while device discoverable is turned off
Depends on: 1194049
Summary: [Presentation WebAPI] provide device ID to TCPPresentationServer while device discoverable is turned off → [Presentation WebAPI] regression after changing device Id from service name to host name
Assignee: nobody → schien
Attachment #8673064 - Attachment is obsolete: true
Status: NEW → ASSIGNED
test case included.
Attachment #8675982 - Attachment is obsolete: true
Attachment #8675998 - Flags: review?(xeonchen)
Attachment #8675998 - Flags: review?(xeonchen) → review+
rebase for bug 1200132. will mark 'checkin-needed' after bug 1200132 landed.
Attachment #8675998 - Attachment is obsolete: true
Attachment #8676694 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/a347985a7a1e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.