1214179 - [Presentation WebAPI] regression after changing device Id from service name to host name

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: self-host-resolution.patch

After 1194049 landed, TCPPresentationServer uses mDNS host name for indexing available devices. On receiver side we need to found the matched device with the |id| in sessionInit message. Therefore we need to query the self host name on sender side as well.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8673064 [details] [diff] [review]
self-host-resolution.patch

I also resolved one device list maintenance bug as well. We need to remove items from |mDevices| if TCPPresentationServer is restarted (e.g. while network status change).

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: bug1214179-set-id-for-controller.patch

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: bug1214179-set-id-for-controller.patch

test case included.

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b938f6bc13a4

Comment 5

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=45bc59996cda

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: bug1214179-set-id-for-controler.patch

rebase for bug 1200132. will mark 'checkin-needed' after bug 1200132 landed.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a347985a7a1e

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a347985a7a1e