Closed Bug 1214316 Opened 6 years ago Closed 6 years ago

Improve assertions on top level remote accessible doc handling

Categories

(Core :: Disability Access APIs, defect)

36 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(3 files)

Attached patch v1Splinter Review
The assertion in OuterDocAccessible::RemoteChildDoc() can easily fire if we haven't yet initialized the remote part.

TabParent::GetTopLevelDocAccessible() on the other hand should assert that if we don't have a top level accessible doc, we shouldn't have any other docs either.
Attachment #8673236 - Flags: review?(tbsaunde+mozbugs)
Comment on attachment 8673236 [details] [diff] [review]
v1

>   if (DocAccessibleParent* doc = tab->GetTopLevelDocAccessible()) {
>     return doc;
>   }
> 
>-  MOZ_ASSERT(false, "no top level tab document?");
>   return nullptr;

might as well just be return tab->GetTopLevelDocAccessible() right?
Attachment #8673236 - Flags: review?(tbsaunde+mozbugs) → review+
Well, I thought you want minimal patches ;) But sure.
Attached patch v2Splinter Review
Attached patch exportSplinter Review
https://hg.mozilla.org/mozilla-central/rev/47725c1ad2b5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.