1214316 - Improve assertions on top level remote accessible doc handling

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v1

The assertion in OuterDocAccessible::RemoteChildDoc() can easily fire if we haven't yet initialized the remote part.

TabParent::GetTopLevelDocAccessible() on the other hand should assert that if we don't have a top level accessible doc, we shouldn't have any other docs either.

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8673236 [details] [diff] [review]
v1

>   if (DocAccessibleParent* doc = tab->GetTopLevelDocAccessible()) {
>     return doc;
>   }
> 
>-  MOZ_ASSERT(false, "no top level tab document?");
>   return nullptr;

might as well just be return tab->GetTopLevelDocAccessible() right?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Well, I thought you want minimal patches ;) But sure.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: export

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/47725c1ad2b5

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/47725c1ad2b5