Disable leak sanitizer when building ICU

RESOLVED FIXED in Firefox 44

Status

RESOLVED FIXED
3 years ago
10 months ago

People

(Reporter: Ehsan, Unassigned)

Tracking

unspecified
mozilla44

Firefox Tracking Flags

(firefox44 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Otherwise, clang 3.7 address sanitizer detects leaks when running genrb: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd23d884f20e
Maybe we should force to build host and target separately even in the non-cross-compile case, and build the host parts without *san.
(Reporter)

Comment 2

3 years ago
The host tools are only executed during the build, so that will effectively give us the same result as turning things such as leak sanitizer off at runtime.  I'm not sure how useful it is to disable sanitizers for all host tools.  For our own host tools, I prefer fixing bugs in them...
(Reporter)

Comment 3

3 years ago
Created attachment 8675126 [details] [diff] [review]
Don't detect leaks during ICU build
Attachment #8675126 - Flags: review?(mh+mozilla)
Attachment #8675126 - Flags: review?(mh+mozilla) → review+

Comment 5

3 years ago
backoutbugherdermerge
https://hg.mozilla.org/mozilla-central/rev/d4e0e0e5d26d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

Updated

10 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.