Closed Bug 1214464 Opened 9 years ago Closed 9 years ago

Disable leak sanitizer when building ICU

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla44
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

Attachments

(1 file)

Don't detect leaks during ICU build
1.40 KB, patch
glandium
: review+
Details | Diff | Splinter Review 
Otherwise, clang 3.7 address sanitizer detects leaks when running genrb: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd23d884f20e
Maybe we should force to build host and target separately even in the non-cross-compile case, and build the host parts without *san.
The host tools are only executed during the build, so that will effectively give us the same result as turning things such as leak sanitizer off at runtime.  I'm not sure how useful it is to disable sanitizers for all host tools.  For our own host tools, I prefer fixing bugs in them...

        Attachment #8675126 -
        Flags: review?(mh+mozilla)

        Attachment #8675126 -
        Flags: review?(mh+mozilla) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d4e0e0e5d26d
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox44:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: