Closed
Bug 1214464
Opened 10 years ago
Closed 9 years ago
Disable leak sanitizer when building ICU
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox44 fixed)
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: ehsan.akhgari, Unassigned)
References
Details
Attachments
(1 file)
1.40 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Otherwise, clang 3.7 address sanitizer detects leaks when running genrb: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bd23d884f20e
Comment 1•10 years ago
|
||
Maybe we should force to build host and target separately even in the non-cross-compile case, and build the host parts without *san.
Reporter | ||
Comment 2•10 years ago
|
||
The host tools are only executed during the build, so that will effectively give us the same result as turning things such as leak sanitizer off at runtime. I'm not sure how useful it is to disable sanitizers for all host tools. For our own host tools, I prefer fixing bugs in them...
Reporter | ||
Comment 3•10 years ago
|
||
Attachment #8675126 -
Flags: review?(mh+mozilla)
Updated•9 years ago
|
Attachment #8675126 -
Flags: review?(mh+mozilla) → review+
Comment 5•9 years ago
|
||
backout bugherder merge |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•